Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Placement is not updated when the SyncTarget Heartbeat condition changes #2579

Closed
davidfestal opened this issue Jan 10, 2023 · 2 comments · Fixed by #2624
Closed

bug: Placement is not updated when the SyncTarget Heartbeat condition changes #2579

davidfestal opened this issue Jan 10, 2023 · 2 comments · Fixed by #2624
Assignees
Labels
area/transparent-multi-cluster Related to scheduling of workloads into pclusters. kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@davidfestal
Copy link
Member

Describe the bug

When the hearbeat condition of a SyncTarget changes (syncer started / stopped), this should impact placements which point to the location workspace containing this location.
That's not the case anymore on main.
That means that id a Syncer is started after KCP is running, and the SyncTarget becomes Ready, it will still not be taken in account by the placement scheduler.

Steps To Reproduce

  1. Run KCP
  2. Create a location workspace,
  3. In the location workspace create a SyncTarget with the workload sync CLI command
  4. Create a workload workspace and bind it to the location workspace with the bind compute CLI command
  5. The placement created during bind will not be scheduled, and will have the No Valid SyncTargets message in the related condition.
  6. Now start the syncer related to the Synctarget, and wait for the SyncTarget (in the location workspace) to be Ready
  7. The Placement in the workload workspace should be updated and scheduled to the SyncTarget but it is not.

Expected Behaviour

When the hearbeat condition of a SyncTarget changes (syncer started / stopped), this should impact placements which point to the location workspace containing this location.

Additional Context

No response

@davidfestal davidfestal added kind/bug Categorizes issue or PR as related to a bug. area/transparent-multi-cluster Related to scheduling of workloads into pclusters. labels Jan 10, 2023
@ncdc ncdc added this to kcp Jan 10, 2023
@github-project-automation github-project-automation bot moved this to New in kcp Jan 10, 2023
@davidfestal davidfestal moved this from New to Next in kcp Jan 10, 2023
@davidfestal
Copy link
Member Author

I started observing this after the workspace refactoring.
@sttts any idea ?

@davidfestal
Copy link
Member Author

cc @qiujian16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transparent-multi-cluster Related to scheduling of workloads into pclusters. kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants