Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all the TMC-related controller to use the cache informers where necessary #2900

Closed
4 tasks done
Tracked by #47
davidfestal opened this issue Mar 15, 2023 · 1 comment · Fixed by #2939 or #2948
Closed
4 tasks done
Tracked by #47
Assignees
Labels
area/transparent-multi-cluster Related to scheduling of workloads into pclusters.

Comments

@davidfestal
Copy link
Member

davidfestal commented Mar 15, 2023

The various TMC-related controllers (called from tmc/pkg/server/controllers.go), for example for scheduling as well as SyncTarget API management, should use the cache informers for things like APIExports, SyncTargets, LogicalCluster resources.

It has been done on the TMC core side, everything is still TBD on the TMC side.

Here is a list of where changes should be done to use cache informers instead of shard-local informers:

@ncdc ncdc added this to kcp Mar 15, 2023
@github-project-automation github-project-automation bot moved this to New in kcp Mar 15, 2023
@davidfestal davidfestal added the area/transparent-multi-cluster Related to scheduling of workloads into pclusters. label Mar 15, 2023
@davidfestal davidfestal moved this from New to Next in kcp Mar 15, 2023
@nrb nrb self-assigned this Mar 15, 2023
@davidfestal davidfestal moved this from Next to In Progress in kcp Mar 23, 2023
@davidfestal davidfestal moved this from In Progress to In Review in kcp Apr 4, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in kcp Apr 5, 2023
@davidfestal davidfestal reopened this Apr 5, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in kcp Apr 5, 2023
@davidfestal
Copy link
Member Author

PR #2948 still needs to be merged in order to fix the issue

@github-project-automation github-project-automation bot moved this from In Progress to Done in kcp Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transparent-multi-cluster Related to scheduling of workloads into pclusters.
Projects
Status: Done
2 participants