Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Rows Definition - remove deprecated properties. #57

Open
pivnicek opened this issue Aug 31, 2018 · 5 comments
Open

Config Rows Definition - remove deprecated properties. #57

pivnicek opened this issue Aug 31, 2018 · 5 comments

Comments

@pivnicek
Copy link
Contributor

pivnicek commented Aug 31, 2018

The enable/disable for configRow configurations is handled via the docker runner api so the config property is deprecated.

Properties to be removed for ConfigRow definition:

  • id
  • name
  • enabled

This may require a minor change to the frontend to filter out these properties before saving.

@Halama
Copy link
Member

Halama commented Aug 31, 2018

what about that id is it anyhow useful? I think it can be removed.

image

@pivnicek
Copy link
Contributor Author

yes, let's get rid of that at the same time, good idea. It is redundant with the rowConfigId

@Halama
Copy link
Member

Halama commented Aug 31, 2018

do you know if ui is using it? If not we can remove it from teradata rightnow, because it is not used inside the extractor.

@pivnicek
Copy link
Contributor Author

I'm 95% sure that it is not used, but I'll confirm right now, brb

@pivnicek
Copy link
Contributor Author

Yes, I think we are safe to remove id from the configRow definition. Btw, similarly, I think we can remove name too as it uses the configRow name.

@Halama Halama mentioned this issue Aug 31, 2018
14 tasks
@pivnicek pivnicek changed the title Config Rows enabled property is deprecated. Config Rows Definition - remove deprecated properties. Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants