Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations are not on spec-level for our deployments #35

Closed
tomkerkhove opened this issue Apr 1, 2020 · 1 comment
Closed

Annotations are not on spec-level for our deployments #35

tomkerkhove opened this issue Apr 1, 2020 · 1 comment
Assignees
@tomkerkhove
Labels
bug Something isn't working

Comments

@tomkerkhove
Copy link
Member

The annotations for using kube2iam are in the wrong location in helm chart package...

12-keda-deployment.yaml
22-metrics-deployment.yaml
should be at the spec level in the deployment

Reported by @bmacauley-reward

Relates to kedacore/keda#706
@tomkerkhove tomkerkhove added the bug Something isn't working label Apr 1, 2020
@tomkerkhove tomkerkhove mentioned this issue Apr 1, 2020
Closed
@tomkerkhove tomkerkhove self-assigned this Apr 1, 2020
@ncrothe ncrothe mentioned this issue Apr 1, 2020
Merged
@tomkerkhove
Copy link
Member Author

Fixed via #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomkerkhove tomkerkhove

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomkerkhove