Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helm-docs to document params in README.md #444

Closed
mkilchhofer opened this issue May 16, 2023 · 5 comments · Fixed by #446
Closed

Use helm-docs to document params in README.md #444

mkilchhofer opened this issue May 16, 2023 · 5 comments · Fixed by #446
Assignees

Comments

@mkilchhofer
Copy link
Contributor

I'd like to introduce https://github.com/norwoodj/helm-docs for documenting the possible parameters.

Use-Case

It's hard to follow if every param is up-to-date on a PR. We at argo-helm use helm-docs to mitigate this.

Specification

  • Update values.yaml with helm-docs comment above each key/param
  • Introduce helm-docs
  • Update contributor docs about helm-docs
@zroubalik
Copy link
Member

Sounds good, thanks! Any improvement on Helm charts is more then welcome!

@JorTurFer
Copy link
Member

Your PRs look awesome, I need some time to review the tool and how it works, but they are promising ❤️
Thanks for them!

@tomkerkhove
Copy link
Member

Thanks for the PRs; I merged one but added comment here: https://github.com/kedacore/charts/pull/447/files#r1222944083

Once that is clear we can tweak it further!

Would you mind opening a PR to the contribution guide to document how this works and how to generate things please?

@mkilchhofer
Copy link
Contributor Author

I answered in the mentioned PR.

Regarding how to use it, I already made a description in the CONTRIBUTING.md (it's part ot the keda PR)

@tomkerkhove
Copy link
Member

Regarding how to use it, I already made a description in the CONTRIBUTING.md (it's part ot the keda PR)

Oh OK, my bad. I was waiting to review that one until the HTTP one is in since it's smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants