Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for metricRelabelings to Pod and Service monitors #514

Closed
pragmaticivan opened this issue Aug 29, 2023 · 2 comments · Fixed by #603
Closed

Add support for metricRelabelings to Pod and Service monitors #514

pragmaticivan opened this issue Aug 29, 2023 · 2 comments · Fixed by #603

Comments

@pragmaticivan
Copy link
Contributor

prometheus/prometheus#5200

name is not available in relabelings.

Use-Case

To perform something like:

- sourceLabels: [__name__]
      regex: ^keda_scaler_errors$
      targetLabel: newrelic_metric_type
      action: replace
      replacement: counter

it would need to go under metricRelabelings instead.

@pragmaticivan
Copy link
Contributor Author

cc @JorTurFer I can take this one if accepted

@JorTurFer
Copy link
Member

Yeah, I think it's a good addition. Not setting them as default keeps current behavior and adding them can extend current options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants