Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not scaling to 0 #214

Closed
ajanth97 opened this issue Jul 29, 2021 · 4 comments · Fixed by #206
Closed

Not scaling to 0 #214

ajanth97 opened this issue Jul 29, 2021 · 4 comments · Fixed by #206
Labels
bug Something isn't working

Comments

@ajanth97
Copy link
Collaborator

Expected Behavior

Scale to 0 when there is no traffic in the HTTP Request queue

Actual Behavior

Always at a minimum of 1 replica

Steps to Reproduce the Problem

I discussed with @arschles and @khaosdoctor about this problem and based on our investigations this behavior is caused by the following:

https://github.com/kedacore/http-add-on/blob/main/scaler/handlers.go#L33-L40

The isActive method here always returns true. Based on this bool KEDA scales to and from 0. If it true we scale from 0 to 1 and if its false the vice-versa.

@ajanth97 ajanth97 added the bug Something isn't working label Jul 29, 2021
@arschles
Copy link
Collaborator

@ajanth97 are you wanting #206 to fix this issue?

@ajanth97
Copy link
Collaborator Author

ajanth97 commented Jul 30, 2021

@ajanth97 are you wanting #206 to fix this issue?

@arschles Yes I'd love to work on the fix.

@arschles
Copy link
Collaborator

arschles commented Aug 2, 2021

@ajanth97 wonderful. care to do it as a branch off of #206? that PR will change a lot of code, so it would likely be more efficient to do it that way

@ajanth97
Copy link
Collaborator Author

ajanth97 commented Aug 3, 2021

Sure will make the change in a new branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants