Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple host feilds in the HttpScaledObject #552

Closed
Kaitou786 opened this issue Dec 6, 2022 · 4 comments · Fixed by #674
Closed

Allow multiple host feilds in the HttpScaledObject #552

Kaitou786 opened this issue Dec 6, 2022 · 4 comments · Fixed by #674
Assignees
Labels

Comments

@Kaitou786
Copy link

Hi, we have a deployment that is exposed via multiple hostname in the ingress; As a workaround, I tried creating multiple HttpScaledObject, and in the targetRef added the same deployment and service with the different host but seem the http-scaller component crashes trying to handle with fatal error: concurrent map writes

Use-Case

Ability to handle multiple host to scale the same deployment

Specification

The HttpScaledObject should accept a list of strings in the host field and the route should be added for all those hosts to the service; i.e. request to any one of those hosts would scale up the service.

@tomkerkhove tomkerkhove added the bug Something isn't working label Dec 6, 2022
@someshkoli
Copy link
Contributor

We have a similar requirement for this, currently using list of httpscaledobject resource. Will raise a PR for this.

@tomkerkhove
Copy link
Member

That would be awesome, thank you @someshkoli!

@abatilo
Copy link
Contributor

abatilo commented Jan 28, 2023

We have a similar requirement for this, currently using list of httpscaledobject resource. Will raise a PR for this.

Do you use different deployments? I wonder if the HTTPScaledObjects would conflict with each other?

@trilitheus
Copy link

also have a use case for this (I think it is the same?) - we have multiple ingresses pointing to the same deployment
demo.domain1.com -> mydemo deployment
demo.domain2.com > mydemo deployment
We do this so we can check the domain and display different branding based on that.
We want to scale the single deployment up no matter which of the URLs you hit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment