Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide overview of egress endpoints #631

Open
tomkerkhove opened this issue Jan 20, 2022 · 12 comments
Open

Provide overview of egress endpoints #631

tomkerkhove opened this issue Jan 20, 2022 · 12 comments
Labels
best-practices documentation Improvements or additions to documentation operations security

Comments

@tomkerkhove
Copy link
Member

Provide overview of egress endpoints that cluster operators should be aware of and allow.

@tomkerkhove tomkerkhove added documentation Improvements or additions to documentation best-practices operations labels Jan 20, 2022
@tomkerkhove
Copy link
Member Author

@kedacore/keda-maintainers Do you have an idea of the endpoints that should be allowed for egress?

@JorTurFer
Copy link
Member

What do you want to achieve? I mean, is this to allow the traffic in network policies or similar?
If yes, it depends on the scaler specifically , maybe we could add a section on every scaler explaining that. In some cases are defined (ex Azure or AWS, etc) and in other cases are user defined (sql servers, prometheus, etc)

@tomkerkhove
Copy link
Member Author

What do you want to achieve? I mean, is this to allow the traffic in network policies or similar?

Some end-users or cloud providers lock down the services they can consume from within a cluster. Depending on the scaler that is being used, that can mean that our scalers will fail because of it.

Examples:

If yes, it depends on the scaler specifically , maybe we could add a section on every scaler explaining that. In some cases are defined (ex Azure or AWS, etc) and in other cases are user defined (sql servers, prometheus, etc)

Yes, that's what I was thinking as well.

@JorTurFer
Copy link
Member

Sounds totally reasonable. My concert here is how to maintain up to date the external vendors' endpoint, but maybe we could point to their specific documentation in case of existing 🤔
But I think this is a fantastic idea from security pov

@tomkerkhove
Copy link
Member Author

Yes, I'd use links to their official documentation so that people have guidance on it and make it a "requirement" for new scaler docs to include them.

@tomkerkhove
Copy link
Member Author

The only question I have is, do we:

  • Add it to every individual scaler doc page, or
  • Provide a dedicated overview in Operate

I'm leaning towards the latter as the audience for our scaler pages are different from the Operate where cluster admins will not go through all scaler pages.

@JorTurFer
Copy link
Member

Maybe we could add a section in Operate saying that each scaler has its own info. Basically because having the info closest to the scaler could be more useful to check/maintain it
WDYT?

@tomkerkhove
Copy link
Member Author

What if the cluster admin doesn't know what scalers are being used or wants to allow all of them?

@JorTurFer
Copy link
Member

Could we generate a summary in base of scaler automatically? 🤔

@tomkerkhove
Copy link
Member Author

I think the main question is, who's the audience? Do devs care about this? I doubt it, to be honest.

We can add a link to the operate page in every scaler doc as well :)

@JorTurFer
Copy link
Member

That's another option 😄

@arschles
Copy link
Contributor

We can add a link to the operate page in every scaler doc as well :)

Seems like the best way to get started IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best-practices documentation Improvements or additions to documentation operations security
Projects
None yet
Development

No branches or pull requests

3 participants