Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redirect rules and drop misnamed and misplaced _redirects files #668

Closed
1 of 3 tasks
chalin opened this issue Feb 18, 2022 · 24 comments · May be fixed by #816
Closed
1 of 3 tasks

Fix redirect rules and drop misnamed and misplaced _redirects files #668

chalin opened this issue Feb 18, 2022 · 24 comments · May be fixed by #816
Assignees
@chalin
Labels
enhancement New feature or request stale All issues that are marked as stale due to inactivity website

Comments

@chalin
Copy link
Contributor

chalin commented Feb 18, 2022 •
edited
Loading

Redirect rules should be defined in layouts/index.redirects.

The following two files should be deleted. We might need to ensure that their rules are covered first thought:
@tomkerkhove tomkerkhove added this to the Documentation Improvements milestone Feb 21, 2022
@chalin chalin changed the title [cleanup] Drop content/_redirects Fix redirect rules and drop misnamed and misplaced _redirects files Feb 21, 2022
@chalin
Copy link
Contributor Author

chalin commented Feb 21, 2022

@tomkerkhove - as was mentioned in the opening comment, the following rules aren't being processed by Netlify:

keda-docs/static/_redirects

Lines 1 to 4 in edde5ff

/concepts/* /docs/concepts/:splat
/concepts/overview /docs/concepts
/deploy/* /docs/deploy/:splat
/faq/* /docs/faq/

Some of these are encoded in the layouts/index.redirects, but not all. Do you need these rules?

Also note that the deploy redirect rule is missing a /. That is:

/cc @nate-double-u

/tag cleanup
/tag bug

@chalin chalin mentioned this issue Feb 21, 2022
Merged
@tomkerkhove
Copy link
Member

Yes, we need those indeed but these should work normally; for example if you go to https://keda.sh/docs/latest/scalers/ it will go to https://keda.sh/docs/2.6/scalers/

But I'm not sure if it's that or because of the versions. If I recall correctly these were there for our old docs, but not a must from my side.

Thoughts @kedacore/keda-maintainers?

@zroubalik
Copy link
Member

Yes, we need those indeed but these should work normally; for example if you go to https://keda.sh/docs/latest/scalers/ it will go to https://keda.sh/docs/2.6/scalers/

But I'm not sure if it's that or because of the versions. If I recall correctly these were there for our old docs, but not a must from my side.

Thoughts @kedacore/keda-maintainers?

+1

@chalin chalin self-assigned this Mar 7, 2022
@chalin
Copy link
Contributor Author

chalin commented Mar 10, 2022

Yes, we need those indeed but these should work normally; for example if you go to https://keda.sh/docs/latest/scalers/ it will go to https://keda.sh/docs/2.6/scalers/

FYI, https://github.com/kedacore/keda-docs/blob/main/static/_redirects get overwritten by the generated file of the same name. All rules have an equivalent in the generated file except for this redirect:

$ curl -s -D - -o /dev/null https://keda.sh/concepts/overview
HTTP/2 404

Just to be clear: so you'd like me to add a rule for concepts/overview?

@tomkerkhove
Copy link
Member

I'd say ensure we have rules for all of these:

keda-docs/static/_redirects

Lines 1 to 4 in edde5ff

/concepts/* /docs/concepts/:splat
/concepts/overview /docs/concepts
/deploy/* /docs/deploy/:splat
/faq/* /docs/faq/

@stale
Copy link

stale bot commented May 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label May 10, 2022
@tomkerkhove
Copy link
Member

Bump

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label May 10, 2022
@stale
Copy link

stale bot commented Jul 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jul 9, 2022
@tomkerkhove tomkerkhove added the enhancement New feature or request label Jul 11, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jul 11, 2022
@nate-double-u nate-double-u mentioned this issue Jul 13, 2022
Open
@tomkerkhove tomkerkhove removed this from the Documentation Improvements milestone Aug 1, 2022
@stale
Copy link

stale bot commented Sep 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Sep 30, 2022
@stale
Copy link

stale bot commented Oct 7, 2022

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Oct 7, 2022
Repository owner moved this from Todo to Done in Documentation Improvements Oct 7, 2022
@chalin chalin reopened this Oct 7, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 7, 2022
@stale
Copy link

stale bot commented Dec 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Feb 5, 2023
@stale
Copy link

stale bot commented Feb 12, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Feb 12, 2023
@JorTurFer
Copy link
Member

Is this solved?

@JorTurFer JorTurFer reopened this Feb 12, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Feb 12, 2023
@stale
Copy link

stale bot commented Apr 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Apr 16, 2023
@JorTurFer
Copy link
Member

Is this solved?

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Apr 17, 2023
@stale
Copy link

stale bot commented Jun 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jun 16, 2023
@stale
Copy link

stale bot commented Jun 23, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jun 23, 2023
@JorTurFer JorTurFer reopened this Jun 23, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jun 23, 2023
@stale
Copy link

stale bot commented Aug 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Aug 23, 2023
@stale
Copy link

stale bot commented Sep 3, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Sep 3, 2023
@JorTurFer JorTurFer reopened this Sep 3, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Sep 3, 2023
@stale Stale
Copy link

stale bot commented Nov 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Nov 3, 2023
@JorTurFer
Copy link
Member

should we mark this as ignored for stale bot?

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Nov 3, 2023
@stale Stale
Copy link

stale bot commented Jan 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 2, 2024
@stale Stale
Copy link

stale bot commented Jan 9, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalin chalin

Labels
enhancement New feature or request stale All issues that are marked as stale due to inactivity website
Projects
Documentation Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updating redirects, removing unreachable files nate-double-u/kedacore-keda-docs
4 participants
@zroubalik @chalin @tomkerkhove @JorTurFer