Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename queueLength to messageCount for Azure Service Bus #1109

Closed
tomkerkhove opened this issue Sep 8, 2020 · 1 comment · Fixed by kedacore/keda-docs#255
Closed

Rename queueLength to messageCount for Azure Service Bus #1109

tomkerkhove opened this issue Sep 8, 2020 · 1 comment · Fixed by kedacore/keda-docs#255
Labels
breaking-change feature-request All issues for new features that have not been committed to needs-discussion scaler-azure-service-bus

Comments

@tomkerkhove
Copy link
Member

Rename queueLength to messageCount or depth for Azure Service Bus given it's a confusing name if you are using Service Bus topics.

Alternative approach would be to introduce subscriptionLength but that feels odd and requires you to change.
@tomkerkhove tomkerkhove added needs-discussion feature-request All issues for new features that have not been committed to scaler-azure-service-bus breaking-change labels Sep 8, 2020
@tomkerkhove
Copy link
Member Author

Thoughts on this @ahmelsayed?

This was referenced Sep 10, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change feature-request All issues for new features that have not been committed to needs-discussion scaler-azure-service-bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename queueLength to messageCount for Azure Service Bus scaler tomkerkhove/keda-docs
1 participant
@tomkerkhove