Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go Modules] KEDA v2 does not work as you expect it. #1319

Closed
n3wscott opened this issue Nov 10, 2020 · 0 comments · Fixed by #1324
Closed

[Go Modules] KEDA v2 does not work as you expect it. #1319

n3wscott opened this issue Nov 10, 2020 · 0 comments · Fixed by #1324
Assignees
Labels
bug Something isn't working

Comments

@n3wscott
Copy link

Imports of KEDA v2 should look like this:

	github.com/kedacore/keda/v2 v2.0.0

And then any imports in go use the v2 path.

But this will not work as the KEDA module did not correctly bump the source code to v2.

See https://github.com/kedacore/keda/blob/main/go.mod

You have two options: fork (copy) all of the code into a v2 folder and leave your go.mod file the same, or add a version to the go mod file and support for v1 updates comes from a branch.

An example of a v2 folder in the module: https://github.com/cloudevents/sdk-go

An example with the versioned folder in the package name: https://github.com/google/go-github/blob/master/go.mod#L1

Please see: knative-extensions/eventing-autoscaler-keda#39 (comment)

@n3wscott n3wscott added the bug Something isn't working label Nov 10, 2020
@n3wscott n3wscott changed the title KEDA v2 does not work as you expect it. [Go Modules] KEDA v2 does not work as you expect it. Nov 10, 2020
@zroubalik zroubalik self-assigned this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants