Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace golint linter with revive #1868

Closed
zroubalik opened this issue Jun 7, 2021 · 2 comments · Fixed by #1901
Closed

Replace golint linter with revive #1868

zroubalik opened this issue Jun 7, 2021 · 2 comments · Fixed by #1901
Labels
good first issue Good for newcomers help wanted Looking for support from community

Comments

@zroubalik
Copy link
Member

zroubalik commented Jun 7, 2021 •
edited
Loading

Proposal

In our linter we are using golint plugin which is deprecated, we should replace it with revive and fix any potential linter problems in the codebase.

keda/.golangci.yml

Line 20 in d75dbee

- golint 

level=warning msg="[runner]  The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive."

Anything else?

Related: #1158
@zroubalik zroubalik added help wanted Looking for support from community good first issue Good for newcomers labels Jun 7, 2021
@Abhay2412
Copy link

I could give this a shot if you would like

@zroubalik
Copy link
Member Author

I could give this a shot if you would like

@Abhay2412 sure! that would be great :)

@zroubalik zroubalik mentioned this issue Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Looking for support from community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

linter: update & use revive instead of golint zroubalik/keda
2 participants
@zroubalik @Abhay2412