ActiveMQ Artemis: Parameters provided in restApiTemplate are again needed to be set in metadata.

[Ritikaa96]

Report

While testing ActiveMQ Artemis Scaler, it was found that even if I provide restAPITemplate, I still would need to provide the parameters : brokerName, brokerAddress, managementEndpoint,queueName.
The restAPITemplate can be generated by these parameters as it's as follows:

"http://<<managementEndpoint>>/console/jolokia/read/org.apache.activemq.artemis:broker=\"<<brokerName>>\",component=addresses,address=\"<<brokerAddress>>\",subcomponent=queues,routing-type=\"anycast\",queue=\"<<queueName>>\"/MessageCount"

On further investigation I stumble upon this function to generate the restAPITemplate here
which again is confusing by the name.

Are we doing this knowingly?

Expected Behavior

• Either restAPITemplate should be generated solely by the given parameters as given in the function.
  or
• the parameters : brokerName, brokerAddress, managementEndpoint,queueName; should not be required when restAPITemplate is given.

Actual Behavior

All Parameters: brokerName, brokerAddress, managementEndpoint,queueName, are needed even if restAPITemplate is given.

Steps to Reproduce the Problem

1. Deploy Activemq Artemis.
2. Use the SO without parameters: brokerName, brokerAddress, managementEndpoint,queueName.
3. Deploy the scaledObject.

Logs from KEDA operator

No response

KEDA Version

2.4.0

Kubernetes Version

1.22

Platform

Any

Scaler Details

ActiveMQ Artemis

Anything else?

No response

[zroubalik]

I think you are right, IMHO if a parameter is provided in restApiTemplate it shouldn't be needed to be set again in the metadata.

@balchua @spoplavskiy @bonky42 WDYT?

[balchua]

I agree its either the restApiTemplate or the broker config.

[bonky42]

I agree, make sense to not set both

[Ritikaa96]

@zroubalik @tomkerkhove @spoplavskiy @balchua there is already a function to provide restAPITemplate from the parameters, the only thing we need is to make the four params optional and a parser to get these parameters from the template URL
I'd be glad to work on this if everyone agrees.

[zroubalik]

@Ritikaa96 that would be nice!

[balchua]

Thanks @Ritikaa96

[Ritikaa96]

Hi @zroubalik , @tomkerkhove , @balchua I've added the functionality to parse out the parameters from restApiTemplate. PTAL

Now there are two options.

1. we add a check to throw an error to users not to provide both restApiTemplate & brokerConfig in metadata.
2. we just mention this information in our scaler's document because when we provide restAPITemplate the code doesn't try to search values of the parameters from config.

what do you suggest?