Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaler for Amazon managed service for Prometheus #2214

Closed
awsvikram opened this issue Oct 25, 2021 · 9 comments · Fixed by #5373
Closed

Scaler for Amazon managed service for Prometheus #2214

awsvikram opened this issue Oct 25, 2021 · 9 comments · Fixed by #5373
Labels
feature All issues for new features that have been committed to help wanted Looking for support from community

Comments

@awsvikram
Copy link

Proposal

AWS' managed solution for Prometheus lets customers ingest metrics without the need to manage environment. It would be nice to have a scaler support for Amazon Managed service for Prometheus

Use-Case

Amazon Managed Prometheus requires sigv4 authentication and the prometheus scaler currently does not support authentication parameters. Creating a scaler for Amazon Prometheus will give customers ability to scale the Kubernetes workloads by directly querying the metrics stored

Anything else?

No response
@awsvikram awsvikram added feature-request All issues for new features that have not been committed to needs-discussion labels Oct 25, 2021
@awsvikram awsvikram changed the title Support Amazon managed service for Prometheus Scaler Scaler for Amazon managed service for Prometheus Oct 25, 2021
@zroubalik
Copy link
Member

zroubalik commented Oct 26, 2021 •
edited
Loading

@ssaish make sense, are you wiling to conribute this feature?

@stale
Copy link

stale bot commented Dec 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Dec 25, 2021
@tomkerkhove tomkerkhove added feature All issues for new features that have been committed to and removed feature-request All issues for new features that have not been committed to labels Dec 26, 2021
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Dec 26, 2021
@tomkerkhove tomkerkhove added help wanted Looking for support from community and removed needs-discussion labels Dec 26, 2021
@tomkerkhove tomkerkhove moved this to Backlog in Roadmap - KEDA Core Feb 10, 2022
@tomkerkhove tomkerkhove moved this from To Do to Proposed in Roadmap - KEDA Core Feb 11, 2022
@williamcodes
Copy link

I would also love to see this, would be great to not need the proxy service recommended by aws as a workaround: https://aws.amazon.com/blogs/mt/proactive-autoscaling-kubernetes-workloads-keda-metrics-ingested-into-aws-amp/

@tomkerkhove
Copy link
Member

We're happy to support it, fi somebody contributes it

@JorTurFer
Copy link
Member

We already support Azure and GCP managed prometheus, so I guess that AWS one would be a nice addition. Recently we have migrated the AWS SDK from v1 to v2, so IIRC, there isn't blockers for moving forward

@JorTurFer
Copy link
Member

Any update on this?

sguruvar pushed a commit to sguruvar/keda that referenced this issue Dec 24, 2023
https://github.com/kedacore/keda/issues/2214
1cdd3c9
@sguruvar sguruvar mentioned this issue Dec 24, 2023
Closed
5 tasks
sguruvar pushed a commit to sguruvar/keda that referenced this issue Dec 24, 2023
https://github.com/kedacore/keda/issues/2214
3afd141 
Signed-off-by: Siva Guruvareddiar <gurusiva@amazon.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Dec 24, 2023
https://github.com/kedacore/keda/issues/2214
0016e00
sguruvar pushed a commit to sguruvar/keda that referenced this issue Dec 24, 2023
https://github.com/kedacore/keda/issues/2214
2281e54
sguruvar pushed a commit to sguruvar/keda that referenced this issue Dec 24, 2023
https://github.com/kedacore/keda/issues/2214
319a8c1
sguruvar pushed a commit to sguruvar/keda that referenced this issue Dec 26, 2023
https://github.com/kedacore/keda/issues/2214
f60c1f3
sguruvar pushed a commit to sguruvar/keda that referenced this issue Dec 29, 2023
https://github.com/kedacore/keda/issues/2214
8575dbc
sguruvar pushed a commit to sguruvar/keda that referenced this issue Dec 29, 2023
https://github.com/kedacore/keda/issues/2214
2abcf4a
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 3, 2024
https://github.com/kedacore/keda/issues/2214
eab9d0e
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 14, 2024
https://github.com/kedacore/keda/issues/2214
1358442
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
https://github.com/kedacore/keda/issues/2214
7c96684
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
https://github.com/kedacore/keda/issues/2214
4aeae78
@sguruvar sguruvar mentioned this issue Jan 15, 2024
Merged
7 tasks
@sguruvar
Copy link
Contributor

Incorporated the changes with SDK v2.. Added the unit and e2e tests.. Spinned up a new AWS AMP instance and the flow works good too.. can someone from Keda reviewer team help merge this PR for closure?

@JorTurFer
Copy link
Member

I've posted some comments on that PR. Apart from that, could you update docs repo as well? (maybe you have already done it but I can't find the PR)

sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
https://github.com/kedacore/keda/issues/2214
70205a0 
Signed-off-by: Siva Guruvareddiar <gurusiva@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
https://github.com/kedacore/keda/issues/2214
19a5de4 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
https://github.com/kedacore/keda/issues/2214
d1eddf1 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
Signed-off-by: Siva Guruvareddiar <gurusiva@amazon.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
48dd3d1 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
5c7c7f2 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
332e51e 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
1ad5671 
Signed-off-by: Siva Guruvareddiar <gurusiva@gmail.com>
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
c29fb15 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
4b53d8e 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
68e52fe 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
ebaa539 
Signed-off-by: Siva Guruvareddiar <gurusiva@gmail.com>
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar pushed a commit to sguruvar/keda that referenced this issue Jan 15, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
8c6a39a 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar added a commit to sguruvar/keda-docs that referenced this issue Jan 16, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
96b38dc 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
@sguruvar sguruvar mentioned this issue Jan 16, 2024
Merged
1 task
sguruvar added a commit to sguruvar/keda that referenced this issue Jan 16, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
8813dad 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar added a commit to sguruvar/keda-docs that referenced this issue Jan 16, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
947b8c5 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar added a commit to sguruvar/keda that referenced this issue Jan 16, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
90f50e5 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar added a commit to sguruvar/keda-docs that referenced this issue Jan 16, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
ef0ff72 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar added a commit to sguruvar/keda that referenced this issue Jan 16, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
f73c7aa 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar added a commit to sguruvar/keda that referenced this issue Jan 17, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
bcafe6f 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar added a commit to sguruvar/keda-docs that referenced this issue Jan 17, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
00be8bd 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
sguruvar added a commit to sguruvar/keda that referenced this issue Jan 18, 2024
@sguruvar
https://github.com/kedacore/keda/issues/2214
3376b82 
Signed-off-by: Siva Guruvareddiar <sivagurunath@gmail.com>
@github-project-automation github-project-automation bot moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature All issues for new features that have been committed to help wanted Looking for support from community
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
6 participants
@zroubalik @sguruvar @tomkerkhove @williamcodes @awsvikram @JorTurFer