Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide scaler for Dynatrace metrics #2411

Closed
davidlm228 opened this issue Dec 20, 2021 · 17 comments · Fixed by #5685
Closed

Provide scaler for Dynatrace metrics #2411

davidlm228 opened this issue Dec 20, 2021 · 17 comments · Fixed by #5685
Assignees
Labels
feature All issues for new features that have been committed to needs-discussion scaler

Comments

@davidlm228
Copy link

Proposal

Provide k8s autoscaling based on Dynatrace Metrics

Scaler Source

Pods

Scaling Mechanics

https://www.dynatrace.com/support/help/dynatrace-api/environment-api/metric-v2/get-all-metrics

Authentication Source

https://www.dynatrace.com/support/help/dynatrace-api/basics/dynatrace-api-authentication

Anything else?

No response

@tomkerkhove
Copy link
Member

Thanks! Are you willing to contribute this?

@davidlm228
Copy link
Author

Yes

@tomkerkhove
Copy link
Member

Awesome, thank you @davidlm228!

@stale
Copy link

stale bot commented Feb 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Feb 20, 2022
@stale
Copy link

stale bot commented Feb 27, 2022

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Feb 27, 2022
@tomkerkhove tomkerkhove reopened this Feb 28, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Feb 28, 2022
@tomkerkhove tomkerkhove added feature All issues for new features that have been committed to stale All issues that are marked as stale due to inactivity labels Feb 28, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Feb 28, 2022
@cyrilico
Copy link
Contributor

cyrilico commented Apr 4, 2024

@tomkerkhove do you know if there is anyone actively looking at this? might have a go at it if not

@JorTurFer
Copy link
Member

There isn't anyone working on this, and we can request a dynatrace account for e2e tests, so there isn't any blocker if you are willing to work on this 😄

@cyrilico
Copy link
Contributor

cyrilico commented Apr 5, 2024

@JorTurFer sounds interesting, I'm willing to give it a shot 🙏

@JorTurFer JorTurFer assigned cyrilico and unassigned davidlm228 Apr 5, 2024
@JorTurFer
Copy link
Member

so, the stage is yours xD

@cyrilico cyrilico mentioned this issue Apr 11, 2024
6 tasks
@cyrilico
Copy link
Contributor

@JorTurFer I believe I have a proposal nearly ready, how to proceed with regards to that account configuration for e2e tests?

@JorTurFer
Copy link
Member

We have the account ready, I just need to know which secrets you need and on which envs vars.
For example, you can see how Datadog e2e test work: https://github.com/kedacore/keda/blob/main/tests/scalers/datadog/datadog_test.go#L252-L254
Once I know the envs that you need, I'll generate the secrets and you can just read them from env vars (they are automatically loaded during CI)

@cyrilico
Copy link
Contributor

Thanks @JorTurFer 🙏 I know I need these:

  • The host (DYNATRACE_HOST), or, in alternative, the environment ID from which the host URL can be built (DYNATRACE_ENV_ID)
  • A token with metrics.ingest scope (DYNATRACE_METRICS_INGEST_TOKEN)
  • A token with metrics.read scope (DYNATRACE_METRICS_READ_TOKEN)

If you prefer to merge both scopes into one token (DYNATRACE_METRICS_TOKEN), that should work fine as well. I believe this is all, but if there's anything missing I'll let you know eventually

@JorTurFer
Copy link
Member

JorTurFer commented Apr 22, 2024

I've created them:

Let me know if you need something else from my side 😄

@cyrilico
Copy link
Contributor

Thanks @JorTurFer ; I believe to use the API the host must be in the format https://<IDENTIFIER>.live.dynatrace.com (at least that's what I need to use with another installation I have access to), if you could make that small change 🙏

@JorTurFer
Copy link
Member

Thanks @JorTurFer ; I believe to use the API the host must be in the format https://<IDENTIFIER>.live.dynatrace.com (at least that's what I need to use with another installation I have access to), if you could make that small change 🙏

Do you mean without the ending slash? np, let me remove it xD

@cyrilico
Copy link
Contributor

Thanks @JorTurFer ; I believe to use the API the host must be in the format https://<IDENTIFIER>.live.dynatrace.com (at least that's what I need to use with another installation I have access to), if you could make that small change 🙏

Do you mean without the ending slash? np, let me remove it xD

No, I mean the subdomain .live instead of .apps in the API URL

@JorTurFer
Copy link
Member

That url redirects to the https://identifier.apps.dynatrace.com/ one, maybe both are supported 🤷
Let's add the e2e tests and when we trigger it in the testing infra we will discover it xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature All issues for new features that have been committed to needs-discussion scaler
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants