Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to specify TLS disabled for Kafka scaler #2608

Closed
gunniwho opened this issue Feb 8, 2022 · 1 comment · Fixed by #2611 or kedacore/keda-docs#648
Closed

No way to specify TLS disabled for Kafka scaler #2608

gunniwho opened this issue Feb 8, 2022 · 1 comment · Fixed by #2611 or kedacore/keda-docs#648
Labels
enhancement New feature or request
Milestone

Comments

@gunniwho
Copy link
Contributor

gunniwho commented Feb 8, 2022

Report

When using the Apache Kafka scaler, you can set the auth parameter tls to enabled for the underlying kafka client to use tls when connecting to the brokers. There is no way however to set tls to anything else to configure tls to be disabled. See here. Now I know that the default behavior is that tls is off but the current behavior is counter-intuitive.

Expected Behavior

tls: disabled is not invalid and means the same as not specifying the parameter

Actual Behavior

The scaler throws an error

Steps to Reproduce the Problem

  1. Create a trigger authentication resource that exposes the tls parameter as "disabled"
  2. Create a kafka scaler that references the trigger auth
  3. The scaler can't be created because the tls value is invalid

Logs from KEDA operator

No response

KEDA Version

2.6.0

Kubernetes Version

1.20

Platform

Amazon Web Services

Scaler Details

Kafka

Anything else?

No response

@gunniwho gunniwho added the bug Something isn't working label Feb 8, 2022
@tomkerkhove tomkerkhove added enhancement New feature or request and removed bug Something isn't working labels Feb 9, 2022
@tomkerkhove tomkerkhove added this to the v2.6.1 milestone Feb 9, 2022
@tomkerkhove
Copy link
Member

Thank you for the PR!

@tomkerkhove tomkerkhove moved this to Backlog in Roadmap - KEDA Core Feb 10, 2022
@zroubalik zroubalik modified the milestones: v2.6.1, v2.7.0 Feb 10, 2022
@tomkerkhove tomkerkhove moved this from To Do to In Progress in Roadmap - KEDA Core Feb 14, 2022
Repository owner moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Feb 14, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
3 participants