Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External scalers receive metric names with internal KEDA core prefix #2640

Closed
2 tasks
tomkerkhove opened this issue Feb 15, 2022 Discussed in #2635 · 4 comments · Fixed by #2890
Closed
2 tasks

External scalers receive metric names with internal KEDA core prefix #2640

tomkerkhove opened this issue Feb 15, 2022 Discussed in #2635 · 4 comments · Fixed by #2890
Assignees
Labels
bug Something isn't working help wanted Looking for support from community

Comments

@tomkerkhove
Copy link
Member

tomkerkhove commented Feb 15, 2022

Discussed in #2635

Originally posted by krishna-kariya February 14, 2022
Hi,
I am testing HTTP-triggered Azure Functions on Azure Arc with Keda version 2.5 and 2.6.1. We have created our external HTTP scaler on Keda for autoscaling.

I am getting the error below in the metrics API server
E0207 02:55:09.412436 1 status.go:71] apiserver received an error that is not an metav1.Status: &errors.errorString{s:"No matching metrics found for s0-upstream_rq_total"}: No matching metrics found for s0-upstream_rq_total.

The hpa shows a similar error:
invalid metrics (4 invalid out of 4), first error is: failed to get s0-upstream_rq_active external metric: unable to get external metric k8se-apps/s0-upstream_rq_active/&LabelSelector{MatchLabels:map[string]string{scaledobject.keda.sh/name: myapp,},MatchExpressions:[]LabelSelectorRequirement{},}: unable to fetch metrics from external metrics API: no matching metrics found for s0-upstream_rq_active

I see that from Keda v2.5 and later, the external metric names are prefixed with "sX-". Is this a new addition?
We have created our external HTTP scaler. Do we need to update our external HTTP scaler with these new metric names?

Any help would be appreciated. Thanks.

Tasklist

  • Fix in KEDA core to pass correct metric name
  • Provide e2e test(s)

End-users can mitigate this in their external scaler to remove the sX- prefix until we have shipped KEDA v2.6.2 or v2.7.0

@tomkerkhove tomkerkhove added the bug Something isn't working label Feb 15, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Feb 15, 2022
@tomkerkhove tomkerkhove moved this from Proposed to To Do in Roadmap - KEDA Core Feb 15, 2022
@tomkerkhove tomkerkhove added the help wanted Looking for support from community label Feb 15, 2022
@JorTurFer
Copy link
Member

if nobody tackles this, next week I'll take a look at it

@tomkerkhove
Copy link
Member Author

Thank you!

@v-shenoy
Copy link
Contributor

v-shenoy commented Apr 5, 2022

Can take a look at this, if noone else is? @JorTurFer

@tomkerkhove
Copy link
Member Author

That would be great, thanks @v-shenoy!

@tomkerkhove tomkerkhove moved this from To Do to In Progress in Roadmap - KEDA Core Apr 5, 2022
Repository owner moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Apr 8, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Looking for support from community
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants