Azure Data Explorer: iter.Next is deprecated: Use NextRowOrError() instead

[zroubalik]

Report

Azure Data Explorer code needs to be updated, I have set an exception to the .golangci.yaml in the meantime:

keda/.golangci.yml

Line 78 in 92fe72f

# remove once https://github.com/kedacore/keda/issues/2989 is fixed

make golangci                                                                                                                                                           
golangci-lint run
pkg/scalers/azure/azure_data_explorer.go:95:14: SA1019: iter.Next is deprecated: Use NextRowOrError() instead for more robust error handling. In a future version, this will be removed, and NextRowOrError will replace it. Next gets the next Row from the query. io.EOF is returned if there are no more entries in the output. This method will fail on errors inline within the rows, even though they could potentially be recovered and more data might be available. Once Next() returns an error, all subsequent calls will return the same error. (staticcheck)
        row, err := iter.Next()
                    ^
pkg/scalers/azure/azure_data_explorer.go:105:11: SA1019: iter.Next is deprecated: Use NextRowOrError() instead for more robust error handling. In a future version, this will be removed, and NextRowOrError will replace it. Next gets the next Row from the query. io.EOF is returned if there are no more entries in the output. This method will fail on errors inline within the rows, even though they could potentially be recovered and more data might be available. Once Next() returns an error, all subsequent calls will return the same error. (staticcheck)
        _, err = iter.Next()

Expected Behavior

golangci pass without an expection

Actual Behavior

iter.Next is deprecated

Steps to Reproduce the Problem

1. make golangci

Logs from KEDA operator

No response

KEDA Version

No response

Kubernetes Version

No response

Platform

No response

Scaler Details

No response

Anything else?

No response

[JorTurFer]

I think that this PR is needed before to have the updated dependency

[zroubalik]

Yeah, I will update this one once it is merged. I needed a link to an issue in the PR chicken-egg problem 😄

[zroubalik]

This needs to be updated once is this issue solved

keda/.golangci.yml

Line 78 in 92fe72f

# remove once https://github.com/kedacore/keda/issues/2989 is fixed