Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for preventing interference of autoscaling a single scale target when creating a new ScaledJob/ScaledObject #3083

Closed
tomkerkhove opened this issue May 30, 2022 · 2 comments · Fixed by kedacore/charts#352
Labels
feature All issues for new features that have been committed to needs-discussion prevention

Comments

@tomkerkhove
Copy link
Member

Proposal

We always recommend people to follow this guidance:

  • Only have one ScaledJob/ScaledObject with multiple triggers, instead of multiple instances
  • Do not mix and match ScaledJob/ScaledObject with your own HPA

However, we don't provide any prevention for this.

KEDA should automatically be rejecting new ScaledObject resources that are created which target a scale target which is already being autoscaled.

This should cover the following scenarios:

  • ScaledJob/ScaledObject targeting workload A, but workload A is already scaled by another ScaledJob/ScaledObject
  • ScaledJob/ScaledObject targeting workload A, but workload A is already scaled by another Horizontal Pod Autoscaler

Use-Case

Prevent end-users from having multiple actors scale workloads, either by accident or on purpose, to prevent flapping due to different criteria.

Anything else?

See #3023 for the discussion

@tomkerkhove tomkerkhove added needs-discussion feature-request All issues for new features that have not been committed to labels May 30, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core May 30, 2022
@tomkerkhove tomkerkhove changed the title Provide support for preventing interference of autoscaling a single scale target Provide support for preventing interference of autoscaling a single scale target with multiple ScaledJob/ScaledObject May 31, 2022
@tomkerkhove tomkerkhove changed the title Provide support for preventing interference of autoscaling a single scale target with multiple ScaledJob/ScaledObject Provide support for preventing interference of autoscaling a single scale target when creating a new ScaledJob/ScaledObject May 31, 2022
@tomkerkhove tomkerkhove added feature All issues for new features that have been committed to prevention and removed feature-request All issues for new features that have not been committed to labels May 31, 2022
@tomkerkhove tomkerkhove moved this from Proposed to To Do in Roadmap - KEDA Core May 31, 2022
@github-project-automation github-project-automation bot moved this from To Do to Ready To Ship in Roadmap - KEDA Core Jan 13, 2023
@tomkerkhove
Copy link
Member Author

Just to be sure; are we effectively checking this today or was it closed by accident? (I think it's fine but just checking)

@JorTurFer
Copy link
Member

It was closed automatically because the feature is fully implemented.
Feature + Docs + Helm chart changes are merged (helm changes merge closed this)

@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature All issues for new features that have been committed to needs-discussion prevention
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants