Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Golang 1.18 #3205

Closed
JorTurFer opened this issue Jun 20, 2022 · 2 comments · Fixed by #3653
Closed

Use Golang 1.18 #3205

JorTurFer opened this issue Jun 20, 2022 · 2 comments · Fixed by #3653
Assignees
@JorTurFer
Labels
stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Jun 20, 2022 •
edited
Loading

Proposal

Bump Golang version to 1.18

Use-Case

No response

Anything else?

No response
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Jun 20, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Jun 20, 2022
@JorTurFer JorTurFer self-assigned this Jun 20, 2022
@JorTurFer
Copy link
Member Author

atm, there are linters without support to go 1.18

WARN [linters context] bodyclose is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] rowserrcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.
WARN [linters context] unparam is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649.

I think that kustomize and operator-sdk supports go 1.18 but doesn't make sense to update till linters have support for it

@JorTurFer JorTurFer moved this from Proposed to To Do in Roadmap - KEDA Core Jun 20, 2022
@JorTurFer JorTurFer mentioned this issue Jun 20, 2022
Closed
@JorTurFer JorTurFer mentioned this issue Jul 6, 2022
Closed
@JorTurFer JorTurFer mentioned this issue Jul 18, 2022
Closed
@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Aug 31, 2022
@JorTurFer JorTurFer added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Aug 31, 2022
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Aug 31, 2022
@tomkerkhove tomkerkhove removed feature-request All issues for new features that have not been committed to needs-discussion labels Aug 31, 2022
This was referenced Sep 8, 2022
Merged
Merged
Repository owner moved this from To Do to Ready To Ship in Roadmap - KEDA Core Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorTurFer JorTurFer

Labels
stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump Golang to 1.18.6 JorTurFer/keda
2 participants
@tomkerkhove @JorTurFer