Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Kafka SASL MSK IAM authentication #3431

Closed
pragmaticivan opened this issue Jul 27, 2022 · 11 comments
Closed

Support Kafka SASL MSK IAM authentication #3431

pragmaticivan opened this issue Jul 27, 2022 · 11 comments
Labels
help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@pragmaticivan
Copy link
Contributor

Proposal

MSK (Kafka Managed Services from AWS) supports IAM for authentication via SASL.

ref: segmentio/kafka-go#661

Use-Case

ServiceAccount should be able to be used for Kafka authentication.

Anything else?

No response
@pragmaticivan pragmaticivan added feature-request All issues for new features that have not been committed to needs-discussion labels Jul 27, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Jul 27, 2022
@pragmaticivan pragmaticivan changed the title Support Kafka SASL MSK IAM Support Kafka SASL MSK IAM authentication Jul 27, 2022
@tomkerkhove
Copy link
Member

Fair ask! Are you willing to contribute this?

@tomkerkhove tomkerkhove added help wanted Looking for support from community and removed needs-discussion feature-request All issues for new features that have not been committed to labels Aug 1, 2022
@pragmaticivan
Copy link
Contributor Author

I might be able to help but will take quite some time (Still refreshing my skills with go) 😂 If anyone else has the need for this feature asap.

@stale
Copy link

stale bot commented Jan 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Jan 13, 2023
@zroubalik zroubalik removed the stale All issues that are marked as stale due to inactivity label Jan 13, 2023
@stale
Copy link

stale bot commented Mar 14, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Mar 14, 2023
@zroubalik zroubalik added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Mar 17, 2023
@stale
Copy link

stale bot commented Mar 24, 2023

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Mar 24, 2023
@github-project-automation github-project-automation bot moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Mar 24, 2023
@JorTurFer JorTurFer moved this from Ready To Ship to Abanoned in Roadmap - KEDA Core Jun 1, 2023
@JorTurFer JorTurFer reopened this Jun 1, 2023
@github-project-automation github-project-automation bot moved this from Abanoned to Proposed in Roadmap - KEDA Core Jun 1, 2023
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Jun 1, 2023
@JorTurFer JorTurFer moved this from Proposed to To Do in Roadmap - KEDA Core Jun 1, 2023
@sansmoraxz sansmoraxz mentioned this issue Jun 16, 2023
Closed
This was referenced Jul 15, 2023
Merged
Merged
@pragmaticivan
Copy link
Contributor Author

Should this be closed?
cc @zroubalik

@zroubalik zroubalik moved this from To Do to Done in Roadmap - KEDA Core Nov 1, 2023
@github-project-automation github-project-automation bot moved this from Done to Ready To Ship in Roadmap - KEDA Core Nov 1, 2023
@Manicben
Copy link

Manicben commented Feb 5, 2024

Understand that the experimental scaler is based on kafka-go and supports MSK IAM via the custom SASL mechanism, but just as an FYI, AWS released an alternative based on SASL-OAUTHBEARER which works with all Go-based Kafka libraries.

Just wanted to highlight this in case it made any difference to the future of the non-experimental and experimental Kafka scalers.

AWS announcement from Nov 2023
GH repo including examples for Sarama

@JorTurFer
Copy link
Member

@dttung2905 @zroubalik . Wasn't the support to MSK IAM the only reason for the new scaler? I mean, could we unify both into the original one adding support to MSK IAM thanks to this?

@dttung2905
Copy link
Contributor

@JorTurFer sorry for the late reply. Its been a busy week for me. Iirc, supporting MSK IAM was a main reason, besides better support and documentation as outlined in #4692.

What's our policy when it comes to deprecating scaler ? Do we follow N-2 cycle too? I took at look at the doc but its not clear too me on scaler deprecation https://github.com/kedacore/governance/blob/main/DEPRECATIONS.md

@JorTurFer
Copy link
Member

The first step is to figure out if the experimental scaler brings extra features (not only now but also in the future) or its just for AWS

@dttung2905
Copy link
Contributor

dttung2905 commented Feb 10, 2024 •
edited
Loading

The first step is to figure out if the experimental scaler brings extra features (not only now but also in the future) or its just for AWS

Its a really good point to bring up during our next community meet up! We can discuss more indept there 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@pragmaticivan @zroubalik @tomkerkhove @Manicben @dttung2905 @JorTurFer