cron scaler metricType shouldn't be configurable

[amirschw]

Proposal

For the cron trigger to scale to the number specified in metadata.desiredReplicas, it must use the AverageValue metric type. Otherwise (if Value is used), based on the HPA algorithm, it will scale to [currentReplicas * desiredReplicas] instead. Therefore, we should probably disallow changing the metricType for this specific scaler.

Use-Case

No response

Anything else?

Related to #2309 where we introduced the option to set the metricType.

[amirschw]

Will be happy to do it myself if there's no objection

[JorTurFer]

Makes sense, excellent catch!

I have already assigned this issue to you ❤️

[tomkerkhove]

Not sure if we should continue investing in cron-scaler or should start #3566 with this instead

[amirschw]

Thanks, I'll wait for the outcome of the discussion there before starting this.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed due to inactivity.