Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement e2e tests where ScaledObject is updated #3870

Closed
Tracked by #2357
zroubalik opened this issue Nov 16, 2022 · 0 comments · Fixed by #4265
Closed
Tracked by #2357

Implement e2e tests where ScaledObject is updated #3870

zroubalik opened this issue Nov 16, 2022 · 0 comments · Fixed by #4265
Assignees
@gauron99
Labels
good first issue Good for newcomers help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot testing

Comments

@zroubalik
Copy link
Member

zroubalik commented Nov 16, 2022 •
edited
Loading

Proposal

We should cover multiple scenarious, probalby in internals package of e2e test.

  • Deploy ScaledObject with 1 trigger -> update value in the trigger -> check that scaling works
  • Deploy ScaledObject with 1 trigger -> add another trigger -> check that scaling works
  • Deploy ScaledObject with 2 triggers -> remove 1 trigger -> check that scaling works
  • Deploy ScaledObject with 3 triggers (where one trigger is cpu/mem scaler) -> update 1 trigger -> check that scaling works
  • Deploy ScaledObject and scale to max replicas-> update max replicas -> check that scaling to new max works
  • ...

https://github.com/kedacore/keda/tree/main/tests/internals

https://github.com/kedacore/keda/blob/main/tests/README.md

Use-Case

No response

Anything else?

No response
@zroubalik zroubalik added help wanted Looking for support from community feature-request All issues for new features that have not been committed to testing good first issue Good for newcomers stale-bot-ignore All issues that should not be automatically closed by our stale bot and removed feature-request All issues for new features that have not been committed to labels Nov 16, 2022
@JorTurFer JorTurFer mentioned this issue Jan 23, 2023
Open
35 tasks
@gauron99 gauron99 mentioned this issue Feb 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauron99 gauron99

Labels
good first issue Good for newcomers help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot testing
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

new internals SO updates tests gauron99/keda
2 participants
@zroubalik @gauron99