Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Increase logging V-level in Apache Kafka scaler #3948

Closed
dkv opened this issue Dec 2, 2022 · 2 comments
Closed

Improvement: Increase logging V-level in Apache Kafka scaler #3948

dkv opened this issue Dec 2, 2022 · 2 comments

Comments

@dkv
Copy link
Contributor

dkv commented Dec 2, 2022

Description:

The Apache Kafka scaler logs stuff at V(1) level in all cases but one, that uses V(0).
V(0) makes it impossible to suppress those logs, and in our case it's a lot of logging.

Proposal:

Log everything in the Apache Kafka scaler with at least V(1)

Tiny change. Change 0 -> 1 in: https://github.com/kedacore/keda/blob/main/pkg/scalers/kafka_scaler.go#L423

@zroubalik
Copy link
Member

@dkv make sense, mind opening a PR to fix this please?

@JorTurFer
Copy link
Member

This is already done: #3953

Repository owner moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Dec 9, 2022
@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants