-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keda doesn't work with TLS inspection #4046
Comments
I have never heard about TLS inspection but after a short investigation, I guess this makes sense totally in some scenarios, but I think that this should be fixed at controller level, not as part of a scaler (I feel this CAs as restricted things, with a limted access to administrators). rootCAs, _ := x509.SystemCertPool()
if rootCAs == nil {
rootCAs = x509.NewCertPool()
}
if certVolume != "" {
// Read in the cert file from volume
certs, err := ioutil.ReadFile(certVolume)
if err != nil {
log.Fatalf("Failed to append %q to RootCAs: %v", localCertFile, err)
}
}
config := &tls.Config{
InsecureSkipVerify: unsafeSsl,
RootCAs: rootCAs,
} In case of given certificates. I'm thinking about passing them as volume (or volumes), maybe using a specific path as convention and just including all certificates from there. WDYT @kedacore/keda-core-contributors ? We can extend the helm chart to cover this scenario, mounting them to the specific path |
Just a brain dump: we can do this approach of mounting this stuff to operator, or we can maybe extend TriggerAuth to allow do this on a scaler level? Would it make sense? Maybe both approaches? |
I'd say both might make sense where operator can be default unless overridden by TriggerAuth? |
We could do at both levels yes, maybe we can introduce a section in the TriggerAuth for TLS trusted CAs. We can register in they system cert pool all the global trusted CAs and in the http client cert pool the CAs for a single trigger. |
@Zurielevi , |
I have noticed that there is no parameter to configure cabundle for TLS inspection support.
(Specific with azure log analytics scaler)
Thanks!
The text was updated successfully, but these errors were encountered: