Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement e2e test for Fallback #4129

Closed
Tracked by #2357
zroubalik opened this issue Jan 17, 2023 · 0 comments · Fixed by #4236
Closed
Tracked by #2357

Implement e2e test for Fallback #4129

zroubalik opened this issue Jan 17, 2023 · 0 comments · Fixed by #4236
Assignees
@gauron99
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community testing

Comments

@zroubalik
Copy link
Member

Proposal

Fallback is currently covered only by unit tests: https://github.com/kedacore/keda/blob/ad751c95500b97c71de087925ef481c988e61e7e/pkg/fallback/fallback_test.go

We should add a proper e2e test, probably into https://github.com/kedacore/keda/tree/main/tests/internals

Use-Case

No response

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response
@zroubalik zroubalik added help wanted Looking for support from community good first issue Good for newcomers feature-request All issues for new features that have not been committed to testing labels Jan 17, 2023
@JorTurFer JorTurFer mentioned this issue Jan 23, 2023
Open
35 tasks
@gauron99 gauron99 mentioned this issue Feb 14, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauron99 gauron99

Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community testing
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

new internals/fallback_test gauron99/keda
2 participants
@zroubalik @gauron99