Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow to remove the finalizer even if the ScaledObject isn't valid #4397

Merged
merged 4 commits into from
Mar 22, 2023
Merged

fix: Allow to remove the finalizer even if the ScaledObject isn't valid #4397

merged 4 commits into from
Mar 22, 2023

Conversation

JorTurFer
Copy link
Member

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4396

@JorTurFer
fix: Allow to remove the finalizer even if the ScaledObject isn't valid
767a0e0 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner March 21, 2023 21:51
@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 21, 2023 •
edited by github-actions bot
Loading

/run-e2e internal*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

@ppanyukov,
FYI: I think that this PR solves your issue deleting invalid ScaledObjects approving any update that only removes the finalizers (unlocking the deletion of those resources)

tomkerkhove
tomkerkhove reviewed Mar 22, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer @tomkerkhove
Update CHANGELOG.md
0a85d27 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@tomkerkhove
Copy link
Member

tomkerkhove commented Mar 22, 2023 •
edited by github-actions bot
Loading

/run-e2e internal*
Update: You can check the progress here

@JorTurFer
use Eventually for unit tests
fe21152 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Mar 22, 2023 •
edited by github-actions bot
Loading

/run-e2e internal*
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) March 22, 2023 11:08
@JorTurFer JorTurFer merged commit 43789f2 into kedacore:main Mar 22, 2023
@JorTurFer JorTurFer deleted the fix-webhooks branch March 22, 2023 11:40
xoanmm pushed a commit to xoanmm/keda that referenced this pull request Mar 22, 2023
@JorTurFer @tomkerkhove @xoanmm
fix: Allow to remove the finalizer even if the ScaledObject isn't val…
f0d901e 
…id (kedacore#4397)

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Apr 13, 2023
@JorTurFer @tomkerkhove
fix: Allow to remove the finalizer even if the ScaledObject isn't val…
2791536 
…id (kedacore#4397)

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Apr 13, 2023
@JorTurFer @tomkerkhove
fix: Allow to remove the finalizer even if the ScaledObject isn't val…
be231a0 
…id (kedacore#4397)

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
JorTurFer added a commit that referenced this pull request Apr 13, 2023
@JorTurFer @zroubalik
@Eldarrin @EugeneLugovtsov @tomkerkhove
Prepare release v2.10.1 (#4449)Co-authored-by: Jorge Turrado Ferrero …
8adb70e 
…<Jorge_turrado@hotmail.es> Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com> Co-authored-by: Eugene Lugovtsov <34510252+EugeneLugovtsov@users.noreply.github.com> fix(aws-sqs): Respect `scaleOnInFlight` value (#4358) fix odd number of arguments passed as key-value pairs for logging (#4369) fix: Azure Pipelines Scaler uses correct endpoint when demands are set  (#4387) (#4401) fix: respect all required demands in azure pipeline scaler (#4405) fix: Allow to remove the finalizer even if the ScaledObject isn't valid (#4397)

* Drop a transitive dependency on bou.ke/monkey (#4366)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* fix(aws-sqs): Respect `scaleOnInFlight` value (#4358)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* chore: update supported versions in the welcome message (#4360)

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* fix odd number of arguments passed as key-value pairs for logging (#4369)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* fix: Azure Pipelines Scaler uses correct endpoint when demands are set  (#4387) (#4401)

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* fix: respect all required demands in azure pipeline scaler (#4405)

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* fix: Allow to remove the finalizer even if the ScaledObject isn't valid (#4397)

Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

* update changelog

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

---------

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Eldarrin <32762846+Eldarrin@users.noreply.github.com>
Co-authored-by: Andy Ward <mortx@toothless.eldarrin.io>
Co-authored-by: Eugene Lugovtsov <34510252+EugeneLugovtsov@users.noreply.github.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admission webhook blocks ScaledObject deletion blocking the finalizer removal
2 participants
@JorTurFer @tomkerkhove