Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to use multihost connection in a PostgreSQLScaler #4704

Closed
a-narsudinov opened this issue Jun 17, 2023 · 0 comments · Fixed by #4705
Closed

Provide a way to use multihost connection in a PostgreSQLScaler #4704

a-narsudinov opened this issue Jun 17, 2023 · 0 comments · Fixed by #4705
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@a-narsudinov
Copy link
Contributor

a-narsudinov commented Jun 17, 2023

Proposal

Right now the PostgreSQL scaler uses a lib/pq library which is outdated and doesn't support a lot of features we are used to in the C version of libpq and its derivatives.

One of them and critical in my eyes is a lack of multi-host connection to highly available PostgreSQL instances.

Right now in case of failover of the master node we have to somehow inform KEDA operator that it should use another connection string/host to pull metrics. That's annoying.

One of the easiest way to fix it - just to replace lib/pq with pgx I guess.

Use-Case

I would like to have a possibility to use multi-host connection strings like this postgresql://airflow:xxxxx@host1,host2:6432/airflow?sslmode=verify-full&target_session_attrs=read-write in a PostgreSQL scaler.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

@a-narsudinov a-narsudinov added feature-request All issues for new features that have not been committed to needs-discussion labels Jun 17, 2023
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant