Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause trigger evaluation #4725

Closed
megacier opened this issue Jun 22, 2023 · 1 comment
Closed

Pause trigger evaluation #4725

megacier opened this issue Jun 22, 2023 · 1 comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@megacier
Copy link

Proposal

Currently, the annotation autoscaling.keda.sh/paused-replicas: "0" doc can be added to pause the scaling.

A similar annotation could be added to stop triggers evaluation as well.
Another option would be to have an annotation that prevents logging on triggers evaluation error.

Use-Case

  1. Maintenance
    When doing maintenance on services used as triggers (e.g. Postgres or metric API) Keda logs error even with autoscaling.keda.sh/paused-replicas: "0" annotation

  2. Night downscaling
    We downscale part of our testing infrastructure at night by setting all replicas to 0 and adding the autoscaling.keda.sh/paused-replicas: "0" annotation. However, as our scaledObject trigger is a metric API kind that targets a service that now points to 0 replicas, Keda logs errors on every evaluation.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@megacier megacier added feature-request All issues for new features that have not been committed to needs-discussion labels Jun 22, 2023
@zroubalik
Copy link
Member

zroubalik commented Jun 22, 2023

This has just been implemented and will be present in the 2.11 release:
#4253

@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Archived in project
Development

No branches or pull requests

2 participants