Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If Github Runner Scaler has a none existent repo it explodes #4790

Closed
Tracked by #4795
Eldarrin opened this issue Jul 13, 2023 · 0 comments · Fixed by #4792
Closed
Tracked by #4795

If Github Runner Scaler has a none existent repo it explodes #4790

Eldarrin opened this issue Jul 13, 2023 · 0 comments · Fixed by #4792
Labels
bug Something isn't working

Comments

@Eldarrin
Copy link
Contributor

Report

I you declare a repo name in the scaler and the repo doesn't exist the scaler does not fail gracefully

Expected Behavior

The error should be graceful and skip the repo

Actual Behavior

Scaler fails and stops processing other repos

Steps to Reproduce the Problem

  1. set TriggerMetadata.repos="blah"

Logs from KEDA operator

example

KEDA Version

2.11.1

Kubernetes Version

1.26

Platform

Microsoft Azure

Scaler Details

github-runner

Anything else?

Will fix
@Eldarrin Eldarrin added the bug Something isn't working label Jul 13, 2023
@Eldarrin Eldarrin mentioned this issue Jul 13, 2023
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Jul 13, 2023
@JorTurFer JorTurFer mentioned this issue Jul 14, 2023
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hotfix repo bug
1 participant
@Eldarrin