Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GCP secret manager for scaler Trigger Authentication #4831

Closed
neelanjan00 opened this issue Jul 30, 2023 · 8 comments · Fixed by #4864
Closed

Support GCP secret manager for scaler Trigger Authentication #4831

neelanjan00 opened this issue Jul 30, 2023 · 8 comments · Fixed by #4864
Assignees

Comments

@neelanjan00
Copy link
Contributor

Proposal

GCP Secret Manager is a storage system for API keys, passwords, certificates, and other sensitive data. It provides a central place and single source of truth to manage, access, and audit secrets across Google Cloud. KEDA should provide support for using GCP Secret Manager for retrieving secret data to be used for scaler trigger authentication.

Use-Case

  • To use GCP Secret Manager for retrieving secret data to be used by scaler trigger authentication.

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

@neelanjan00 neelanjan00 added feature-request All issues for new features that have not been committed to needs-discussion labels Jul 30, 2023
@JorTurFer
Copy link
Member

Hey @neelanjan00 ,
This is an awesome idea to be aligned with the feature that we already support from Azure . Are you willing to contribute with it?
If yes, remember that for e2e tests, you will have to open a PR also to the testing-infrastructure repo 😄

@neelanjan00
Copy link
Contributor Author

Hi Jorge, I am indeed planning to contribute to the feature. After I raise the PR, I will need slight guidance on how to get started with the E2E tests.

@JorTurFer
Copy link
Member

Hi Jorge, I am indeed planning to contribute to the feature. After I raise the PR, I will need slight guidance on how to get started with the E2E tests.

Nice! ❤️
Just let us know when you have questions or need help 😄

@tomkerkhove tomkerkhove moved this from To Triage to In Review in Roadmap - KEDA Core Aug 17, 2023
@tomkerkhove tomkerkhove removed needs-discussion feature-request All issues for new features that have not been committed to labels Aug 17, 2023
@stale
Copy link

stale bot commented Oct 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 16, 2023
@zroubalik zroubalik removed the stale All issues that are marked as stale due to inactivity label Oct 16, 2023
@lsteinberg-r7
Copy link

+1 for this one.
Any update on progress?

@neelanjan00
Copy link
Contributor Author

Hi @liavst2 sorry I had been away on vacation for a while and couldn't close this. @JorTurFer can we merge the PR? We can add unit tests later perhaps since a few other trigger auth providers also lack unit tests.

@zm-alex
Copy link

zm-alex commented Nov 27, 2023

Hi @JorTurFer , is there also a similar feature proposal for AWS Secrets Manager?

@JorTurFer
Copy link
Member

is there also a similar feature proposal for AWS Secrets Manager?

Yeah, it is indeed: #5162

@github-project-automation github-project-automation bot moved this from In Review to Ready To Ship in Roadmap - KEDA Core Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants