Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kafka scaler sasl #486

Merged
merged 5 commits into from
Nov 28, 2019
Merged

add kafka scaler sasl #486

merged 5 commits into from
Nov 28, 2019

Conversation

iyacontrol
Copy link
Contributor

@iyacontrol iyacontrol commented Nov 27, 2019 •
edited
Loading

add support sasl auth(sasl_plaintext,sasl_ssl, sasl_scram_sha256, sasl_scram_sha512) for kafka scaler.

@iyacontrol iyacontrol mentioned this pull request Nov 27, 2019
Closed
@tomkerkhove
Copy link
Member

tomkerkhove commented Nov 27, 2019 •
edited
Loading

Can you send a PR for the docs as well please?

@iyacontrol iyacontrol mentioned this pull request Nov 27, 2019
Merged
jeffhollan
jeffhollan requested changes Nov 27, 2019
View reviewed changes
Copy link
Member

@jeffhollan jeffhollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only big change I see is to make the password property a resolved value rather than a literal value so it should reference a secret

pkg/scalers/kafka_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/kafka_scaler.go Show resolved Hide resolved
jeffhollan
jeffhollan requested changes Nov 28, 2019
View reviewed changes
Copy link
Member

@jeffhollan jeffhollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes - mostly around making sure that the previous ScaledObject ref where auth params weren't defined get defaulted correctly to none for auth mode.

pkg/scalers/kafka_scaler.go Show resolved Hide resolved
pkg/scalers/kafka_scaler_test.go Show resolved Hide resolved
@jeffhollan
Copy link
Member

Tested this out as well with my kafka test and worked well

@jeffhollan
Copy link
Member

Thanks @iyacontrol ! Appreciate the contributions

@jeffhollan jeffhollan merged commit cfea46c into kedacore:master Nov 28, 2019
@iyacontrol iyacontrol deleted the sasl branch November 28, 2019 07:43
@gurukashyap
Copy link

can it also support SSL/TLS?

preflightsiren pushed a commit to preflightsiren/keda that referenced this pull request Nov 7, 2021
@dennis-brinley
Provide documentation for Solace PubSub+ Event Broker scaler (kedacor…
ff9d5a8 
…e#486)

Signed-off-by: Dennis Brinley <dennis.brinley@solace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffhollan jeffhollan jeffhollan approved these changes

@Aarthisk Aarthisk Awaiting requested review from Aarthisk

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iyacontrol @tomkerkhove @jeffhollan @gurukashyap