Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and optimize the fallback logic #5359

Open
JorTurFer opened this issue Jan 10, 2024 · 2 comments
Open

Refactor and optimize the fallback logic #5359

JorTurFer opened this issue Jan 10, 2024 · 2 comments
Labels
help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Jan 10, 2024 •
edited
Loading

Proposal

Before we support parallel request for metrics, we calculated the fallback one by one after each metrics.

After supporting the parallel requesting, we are using the same fallback approach just iterating over all the metrics sequentially to calculate the fallback. As now we have all the info to calculate the fallback with all the metrics at once, we should optimice this process, reducing also the underlying request to k8s api
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Jan 10, 2024
@JorTurFer JorTurFer mentioned this issue Jan 10, 2024
Merged
3 tasks
@gauron99 gauron99 mentioned this issue Jan 21, 2024
Open
@stale Stale
Copy link

stale bot commented Mar 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Mar 10, 2024
@JorTurFer JorTurFer added help wanted Looking for support from community and removed needs-discussion feature-request All issues for new features that have not been committed to stale All issues that are marked as stale due to inactivity labels Mar 10, 2024
@stale Stale
Copy link

stale bot commented May 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label May 10, 2024
@JorTurFer JorTurFer added stale-bot-ignore All issues that should not be automatically closed by our stale bot and removed stale All issues that are marked as stale due to inactivity labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Roadmap - KEDA Core
Status: To Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JorTurFer