app.kubernetes.io/version Label in *-core.yaml Release Asset Should Specify Version

[bdschaap]

Report

The app.kubernetes.io/version label in the keda--core.yaml release asset lists main rather than the actual version. This differs from the keda-.yaml release asset which lists the version.

Expected Behavior

The version is listed in the label of the keda-*-core.yaml release asset.

Actual Behavior

main is listed as the version.

Steps to Reproduce the Problem

1. Download keda-*-core.yaml
2. View the app.kubernetes.io/version labels

Logs from KEDA operator

N/A

KEDA Version

2.11.2

Kubernetes Version

1.26

Platform

Other

Scaler Details

kafka

Anything else?

No response

[JorTurFer]

Hey!
Thanks for reporting! are you willing to draft a PR with the fix?
It should be just adding a line like
@sed -i".out" -e 's@version:[ ].*@version: $(VERSION)@g' config/minimal/kustomize-config/metadataLabelTransformer.yaml during the release target (and the changelog record):

keda/Makefile

Lines 226 to 239 in 6d326c8

	release: manifests kustomize set-version ## Produce new KEDA release in keda-$(VERSION).yaml file.
	cd config/manager && \
	$(KUSTOMIZE) edit set image ghcr.io/kedacore/keda=${IMAGE_CONTROLLER}
	cd config/metrics-server && \
	$(KUSTOMIZE) edit set image ghcr.io/kedacore/keda-metrics-apiserver=${IMAGE_ADAPTER}
	cd config/webhooks && \
	$(KUSTOMIZE) edit set image ghcr.io/kedacore/keda-admission-webhooks=${IMAGE_WEBHOOKS}
	# Need this workaround to mitigate a problem with inserting labels into selectors,
	# until this issue is solved: https://github.com/kubernetes-sigs/kustomize/issues/1009
	@sed -i".out" -e 's@version:[ ].*@version: $(VERSION)@g' config/default/kustomize-config/metadataLabelTransformer.yaml
	rm -rf config/default/kustomize-config/metadataLabelTransformer.yaml.out
	$(KUSTOMIZE) build config/default > keda-$(VERSION).yaml
	$(KUSTOMIZE) build config/minimal > keda-$(VERSION)-core.yaml
	$(KUSTOMIZE) build config/crd > keda-$(VERSION)-crds.yaml

[vinod827]

Can I pick this up?

[vinod827]

Opened the PR# #5518