-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Apache Kafka scaler config #5804
Refactor Apache Kafka scaler config #5804
Conversation
69a2958
to
02fd305
Compare
/run-e2e apache_kafka |
@wozniakjan Oh I did not know you are working on |
my bad, I didn't realize they were similar and I was just going in alphabetical order one scaler at a time. Sure thing, and sorry for the inconvenience. Feel free to open WIP PR with what you have for the |
caee424
to
f905add
Compare
/run-e2e apache_kafka |
ptal @kedacore/keda-contributors, @dttung2905, @SpiritZhou, not sure about the |
I like this |
f905add
to
621bdb9
Compare
/run-e2e |
621bdb9
to
8d9397c
Compare
/run-e2e |
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
8d9397c
to
f0b2949
Compare
/run-e2e |
ptal @kedacore/keda-contributors |
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: uucloud <uucloud@qq.com>
Refactor Apache Kafka scaler config using declarative parser from #5676. This PR also introduces a new field tag option
range
. This tag helps with config options that don't want to enumerate all of the values but instead generate as range (or multiple ranges) bounded by from and to (or multiple from's and to's).Example usage:
keda/pkg/scalers/scalersconfig/typed_config_test.go
Lines 523 to 537 in f905add
Checklist
Relates to #5797