Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Pulsar Scaler #853

Closed
vishal-biyani opened this issue May 22, 2020 · 20 comments · Fixed by #3021
Closed

Apache Pulsar Scaler #853

vishal-biyani opened this issue May 22, 2020 · 20 comments · Fixed by #3021
Labels
feature All issues for new features that have been committed to help wanted Looking for support from community scaler

Comments

@vishal-biyani
Copy link

This is a request for an Apache Pulsar (https://github.com/apache/pulsar) scalar so that Keda users can integrate with Pulsar.

@vishal-biyani vishal-biyani added feature-request All issues for new features that have not been committed to needs-discussion labels May 22, 2020
@tomkerkhove
Copy link
Member

Great idea!

Are you open to contributing this @vishal-biyani ?

@tomkerkhove tomkerkhove added feature All issues for new features that have been committed to help wanted Looking for support from community and removed feature-request All issues for new features that have not been committed to needs-discussion labels Jun 1, 2020
@tomkerkhove tomkerkhove changed the title Apache Pulsar Scalar Apache Pulsar Scaler Jun 1, 2020
@vishal-biyani
Copy link
Author

Hi, @tomkerkhove I would love to contribute but the next 3 weeks is tough based on my schedule. I will update here when I plan to start this one. In meantime are there any good pointers I should look at apart from existing Scalar implementations?

@tomkerkhove
Copy link
Member

No worries at all, take your time!

We are always happy to help on the Kubernetes Slack or you can follow this doc: https://github.com/kedacore/keda/blob/master/CREATE-NEW-SCALER.md

@liangyuanpeng
Copy link
Contributor

Actually, I am working for Pulsar Scaler. Even before I didn’t notice this issue.

@tomkerkhove
Copy link
Member

Well if you want to pick it up @liangyuanpeng, just let me know!

@liangyuanpeng
Copy link
Contributor

@tomkerkhove Yes,I am interested in this. Keda and Pulsar are both amazing things , Thank you for your reply!

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Jun 23, 2020

You may want to take a look at this blog before Pulsar scaler is finished. Creating an External Scaler (Pulsar) for KEDA

@krvarma
Copy link

krvarma commented Jun 24, 2020

@tomkerkhove @liangyuanpeng @vishal-biyani I have created an external scaler for KEDA. It can be easily converted to a built-in scaler. Take a look at this https://medium.com/@krvarma/creating-an-external-scaler-for-keda-31b314b5c4a3. Let me know I can work on the conversion and send a PR.

@tomkerkhove
Copy link
Member

I'm happy with however contributes it so I'll leave it up to you folks to discuss who does what!

@krvarma
Copy link

krvarma commented Jun 26, 2020

@liangyuanpeng @vishal-biyani What you think?

@vishal-biyani
Copy link
Author

@krvarma I am not working on this ATM so I will leave it to you and @liangyuanpeng

@turbaszek
Copy link
Contributor

Hi @krvarma @vishal-biyani @liangyuanpeng any update on this issue? I would love to see Pulsar scaler :)

@krvarma
Copy link

krvarma commented Sep 6, 2020

@turbaszek Since its been long time with no reply from @liangyuanpeng I think it is OK to proceed. I am working on the it and hopefully finish it by couple of weeks. I will keep posing updates.

@tomkerkhove @vishal-biyani

@tomkerkhove
Copy link
Member

Awesome, thanks!

@mmussett
Copy link
Contributor

mmussett commented Mar 9, 2021

Any update on this? If not started can I pick this up?

@tomkerkhove
Copy link
Member

As far as I know, this has not been picked up, thanks for grabbing this one!

@tomkerkhove tomkerkhove mentioned this issue Mar 12, 2021
4 tasks
@vivekpd15
Copy link

Do we have a timeline on when this will get merged? We heavily rely on Pulsar and this feature would be of great help.

@tomkerkhove
Copy link
Member

The PR is still open since it was not ready yet but I've pinged the contributor on #1666

@vivekpd15
Copy link

Thank you @tomkerkhove.

@stale
Copy link

stale bot commented Oct 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 13, 2021
@tomkerkhove tomkerkhove removed the stale All issues that are marked as stale due to inactivity label Oct 14, 2021
@tomkerkhove tomkerkhove moved this to Backlog in Roadmap - KEDA Core Feb 10, 2022
Repository owner moved this from To Do to Ready To Ship in Roadmap - KEDA Core Aug 8, 2022
@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature All issues for new features that have been committed to help wanted Looking for support from community scaler
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants