Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kedro-telemetry logging #31

Closed
Tracked by #1461
antonymilne opened this issue May 18, 2022 · 0 comments · Fixed by #32
Closed
Tracked by #1461

Improve kedro-telemetry logging #31

antonymilne opened this issue May 18, 2022 · 0 comments · Fixed by #32
Assignees

Comments

@antonymilne
Copy link
Contributor

antonymilne commented May 18, 2022

There's two problems with how kedro-telemetry does logging at the moment:

  1. Sometimes it uses click.secho and sometimes it uses logging. This is inconsistent.
  2. Due to changes in Improve logging setup in Kedro kedro#1461, as it stands, no kedro-telemetry logging message that is < WARNING will display now.

For point 1, technically speaking I think both these message should use logging.debug (not info) rather than click.echo. Since by default these messages should not show to a user (confirmed by @yetudada in sprint planning) then setting them to use logging.debug will make them disappear.

So all that should be needed here is modifying L64 and L57 to both use logging.debug, check that the messages disappear when you do kedro run, and update any tests affected.

Note, as per discussion in kedro-org/kedro#1546, at the moment there's no way for a user to change whether or not the kedro-telemetry messages are shown by altering project-side logging.yml because before_command_run hooks are run before that logging configuration is set up. This is fine for now.

@antonymilne antonymilne reopened this May 18, 2022
@antonymilne antonymilne added this to the Improve logging setup milestone May 18, 2022
@merelcht merelcht moved this to Todo in Kedro Framework May 23, 2022
@noklam noklam moved this from Todo to In Progress in Kedro Framework May 23, 2022
@noklam noklam self-assigned this May 24, 2022
@noklam noklam moved this from In Progress to In Review in Kedro Framework May 24, 2022
@noklam noklam linked a pull request May 24, 2022 that will close this issue
4 tasks
Repository owner moved this from In Review to Done in Kedro Framework May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants