Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace identity in kedro telemetry with unique username #50

Closed
SajidAlamQB opened this issue Aug 1, 2022 · 1 comment · Fixed by #58
Closed

Replace identity in kedro telemetry with unique username #50

SajidAlamQB opened this issue Aug 1, 2022 · 1 comment · Fixed by #58
Assignees

Comments

@SajidAlamQB
Copy link
Contributor

Description

This is related to the heap issue. Looking at the kedro-telemetry plugin we currently assign the hashed computer name of users to the identity parameter for Heap. Having a look at the Heap API it makes more sense to assign this to something like username.

Note: The identity parameter needs to be unique, so we may want to find a way to ensure this. (Maybe we hash the concatenation of username and computer name?)

Reason for this:
Heap generates a unique userID that can't be manually changed and isn't related/mapped to the username parameter. However, if heap finds the same identity it will merge that userID into the Heap profile of the identified user.

Context

#36

@yetudada
Copy link
Contributor

yetudada commented Aug 3, 2022

Thank you so much for the investigation on this @SajidAlamQB! I think this is a sensible solution for the matching the user IDs. I don't think we need to combine the hashed_username with hashed_computer_name because they're both hashed. hashed_username should be enough.

@merelcht merelcht moved this to To Do in Kedro Framework Aug 15, 2022
@jmholzer jmholzer moved this from To Do to In Progress in Kedro Framework Aug 22, 2022
@jmholzer jmholzer self-assigned this Aug 22, 2022
@jmholzer jmholzer moved this from In Progress to In Review in Kedro Framework Aug 23, 2022
Repository owner moved this from In Review to Done in Kedro Framework Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants