-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partition Dataset Overwrite not working as expected #601
Comments
@fazilhero This is the expected behavior - https://docs.kedro.org/en/stable/kedro.io.PartitionedDataset.html#kedro.io.PartitionedDataset
Could you elaborate your use case in terms of what you are trying to do? We just have a discussion about kedro-org/kedro#2857 to support versioning of PartitionedDataset, are you trying to overwrite partitions partially, or is that true that versioning of PartitionedDataset is actually what you want? |
What I understood is that when i write a partition |
Sorry for the confusion, I think what you make sense. |
Closed as this is documented expected behavior. If this is a desired feature feel free to open a separate issue for feature request or submit a PR |
Description
Im trying to use the
PartitionedDataset
with overwrite parameter set to True but it overwrites a completely different partition.Context
I have the following partitions in my file storage(s3):
"2023-08-01/se/1/orders"
"2023-08-01/se/3/orders"
"2023-08-01/se/2/orders"
When I have a function which process a single partition like "2023-08-01/se/1/orders" and tries to save this back
with overwrite set to True, it removes all the other partitions.
Suspected error is here with recursive param I believe: https://github.com/kedro-org/kedro/blob/main/kedro/io/partitioned_dataset.py#L308
Steps to Reproduce
Expected Result
Before Save:
"2023-08-01/se/1/orders"
"2023-08-01/se/3/orders"
"2023-08-01/se/2/orders"
After Save:
"2023-08-01/se/1/orders"
"2023-08-01/se/3/orders"
"2023-08-01/se/2/orders"
Actual Result
Before Save:
"2023-08-01/se/1/orders"
"2023-08-01/se/3/orders"
"2023-08-01/se/2/orders"
After Save:
"2023-08-01/se/1/orders"
pip show kedro
orkedro -V
): 0.18.11python -V
): 3.10The text was updated successfully, but these errors were encountered: