Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kedro-telemetry: remove recursive logic to avoid eagerly load commands #794

Closed
noklam opened this issue Jul 31, 2024 · 1 comment · Fixed by #824
Closed

kedro-telemetry: remove recursive logic to avoid eagerly load commands #794

noklam opened this issue Jul 31, 2024 · 1 comment · Fixed by #824
Assignees

Comments

@noklam
Copy link
Contributor

noklam commented Jul 31, 2024

Context

image

I found out telemetry is loading all CLI commands which undermine the effort done in kedro-org/kedro#3883.

Impact

CLI is slow because telemetry always load all the commands.

Description

At first glance, the recursive call does not seems to be necessary as it collects the entire CLI but they are not consume by telemetry later. Maybe all we need is the related command group. 1. is a small comment but we should check telemetry would work consistently for package mode as well.

  1. project_path is not arbitary as it affects the result of recursive call
  2. The recursive call undo the effort of LazyCommand as it eagerly import all the commands.
    Originally posted by @noklam in feat(telemetry): Run telemetry outside of kedro projects #775 (review)
@ankatiyar
Copy link
Contributor

Can I take a stab at this 👀

@merelcht merelcht changed the title kedro-telemetry: remove recursive logic to avoid eagerly load commands kedro-telemetry: remove recursive logic to avoid eagerly load commands Aug 27, 2024
@ankatiyar ankatiyar self-assigned this Aug 28, 2024
@merelcht merelcht moved this to To Do in Kedro Framework Sep 2, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants