Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make starters use OmegaConfigLoader #143

Closed
astrojuanlu opened this issue Aug 17, 2023 · 4 comments · Fixed by #145 or kedro-org/kedro#2974
Closed

Make starters use OmegaConfigLoader #143

astrojuanlu opened this issue Aug 17, 2023 · 4 comments · Fixed by #145 or kedro-org/kedro#2974
Assignees

Comments

@astrojuanlu
Copy link
Member

Description

Right now, the starters show a FutureWarning because they use the ConfigLoader, which is deprecated.

[08/17/23 11:53:39] INFO     Kedro project test-graph                                        session.py:364
                    WARNING  /Users/juan_cano/.micromamba/envs/kedro310/lib/python3.10/site warnings.py:109
                             -packages/kedro/framework/session/session.py:266:                             
                             FutureWarning: ConfigLoader will be deprecated in Kedro 0.19.                 
                             Please use the OmegaConfigLoader instead. To consult the                      
                             documentation for OmegaConfigLoader, see here:                                
                             https://docs.kedro.org/en/stable/configuration/advanced_config                
                             uration.html#omegaconfigloader                                                
                               warnings.warn(   
@ankatiyar
Copy link
Contributor

@astrojuanlu Should this also be changed for the template used for kedro new?

@astrojuanlu astrojuanlu moved this from To Do to In Progress in Kedro Framework Aug 22, 2023
@astrojuanlu
Copy link
Member Author

Relying some offline discussion: yes, this should be done on kedro new as well and can be done in 0.18.x, because kedro run and all commands should work the same for new and old templates (hence this wouldn't be a breaking change).

@noklam noklam linked a pull request Aug 25, 2023 that will close this issue
3 tasks
@noklam
Copy link
Contributor

noklam commented Aug 25, 2023

Linked #145 to this issue. We should also update kedro because the template lives in kedro codebase. @lrcouto

@lrcouto
Copy link
Contributor

lrcouto commented Aug 25, 2023

Update on the kedro repository is on this PR: kedro-org/kedro#2974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
4 participants