Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the directory structure used for starter pipeline tests to match the new structure used on kedro pipeline create #214

Closed
Tracked by #3768
lrcouto opened this issue Apr 3, 2024 · 2 comments · Fixed by #215
Assignees

Comments

@lrcouto
Copy link
Contributor

lrcouto commented Apr 3, 2024

Description

With the changes to the directory structure applied in kedro-org/kedro#3731 now merged, @ankatiyar proposed updating the structure of folders created by the Kedro starters to match them.

Context

The current structure has the pipeline tests created by starters placed in <project root>/tests/pipelines, while the tests created from the kedro pipeline create command go into <project root>/tests/pipelines/<pipeline name>. What is being proposed is to put the pipeline tests from starters into their own directory as well.

For example:

image

In the image above, we can see test_data_science.py that was created by using the spaceflights-pandas starter and is located directly in the tests directory. The test file for my_pipeline, which was created with kedro pipeline create, is on it's own directory.

Possible Implementation

The initial idea would be putting the pipeline tests generated from starters on their own directory. In the aforementioned example, the structure would change from <project root>/tests/pipelines/test_data_science.py to <project root>/tests/pipelines/data_science/test_pipeline.py.

@astrojuanlu
Copy link
Member

Would it make sense to try to fit this for the upcoming 0.19.4 to avoid inconsistencies @merelcht ?

@merelcht
Copy link
Member

merelcht commented Apr 4, 2024

Would it make sense to try to fit this for the upcoming 0.19.4 to avoid inconsistencies @merelcht ?

Yes this must be done before the release.

@astrojuanlu astrojuanlu moved this to To Do in Kedro Framework Apr 4, 2024
@lrcouto lrcouto linked a pull request Apr 10, 2024 that will close this issue
3 tasks
@merelcht merelcht moved this from To Do to In Review in Kedro Framework Apr 11, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants