Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run suggestion in metadata panel to include namespace #1225

Closed
AhdraMeraliQB opened this issue Jan 19, 2023 · 1 comment · Fixed by #1245
Closed

Fix run suggestion in metadata panel to include namespace #1225

AhdraMeraliQB opened this issue Jan 19, 2023 · 1 comment · Fixed by #1245
Assignees
Labels
Issue: Bug Report Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do

Comments

@AhdraMeraliQB
Copy link
Contributor

AhdraMeraliQB commented Jan 19, 2023

Description

The metadata panel will suggest a run command when a node in the pipeline is suggested. However, if the node is within a namespace, this suggestion will not work.

Important note: The formatting of the command is also inconsistent with other Kedro resources. As a result of kedro-org/kedro#2014 command suggestions should now follow the format kedro <command> --<flag>=value1,value2.

Steps to Reproduce

  1. Run kedro run on a new spaceflights project
  2. Run kedro viz
  3. Open metadata panel

Screenshot 2023-01-19 at 16 03 10

  1. Run the suggestion under "Run Command:"

Expected Result

The pipeline should run until the specified node.

Actual Result

The pipeline throws an error.

ValueError: Pipeline does not contain nodes named ['split_data_node']. Did you mean: 
['data_science.active_modelling_pipeline.split_data_node', 
'data_science.candidate_modelling_pipeline.split_data_node']?

Your Environment

Kedro version: 0.18.4
Kedro Viz version: 5.2.0

@tynandebold
Copy link
Member

tynandebold commented Jan 21, 2023

Triage assessment: looks like we need to update package/kedro_viz/models/flowchart.py. Search for run_command.

@tynandebold tynandebold added the Quick Win Low/Medium priorities but quick to do label Jan 30, 2023
@tynandebold tynandebold moved this from Inbox to Backlog in Kedro-Viz Jan 30, 2023
@rashidakanchwala rashidakanchwala moved this from Backlog to In Progress in Kedro-Viz Feb 1, 2023
@rashidakanchwala rashidakanchwala moved this from In Progress to In Review in Kedro-Viz Feb 1, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report Python Pull requests that update Python code Quick Win Low/Medium priorities but quick to do
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants