Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor visualize dataset stats from DataNodeMetadata to DataNode #1482

Closed
ravi-kumar-pilla opened this issue Aug 14, 2023 · 0 comments · Fixed by #1499
Closed

Refactor visualize dataset stats from DataNodeMetadata to DataNode #1482

ravi-kumar-pilla opened this issue Aug 14, 2023 · 0 comments · Fixed by #1499
Assignees
Labels
Enhancement Python Pull requests that update Python code

Comments

@ravi-kumar-pilla
Copy link
Contributor

ravi-kumar-pilla commented Aug 14, 2023

As we plan to move the stats information from Metadata panel to Flowchart, we should move the stats field to be part of DataNode instead of DataNodeMetadata.

Refactor steps -

  1. Remove stats field from DataNodeMetadata class
  2. Update the DataNodeMetadata call from router
  3. Add the stats field inside the data access manager (add_datasets method)
  4. Access the stats field via the DataNode object
  5. Modify the unit tests accordingly
graph_node = GraphNode.create_data_node(
                dataset_name=dataset_name,
                layer=layer,
                tags=set(),
                dataset=obj,
                is_free_input=is_free_input,
                stats = self.get_stats_for_data_node(dataset_name)
            )
@ravi-kumar-pilla ravi-kumar-pilla converted this from a draft issue Aug 14, 2023
@ravi-kumar-pilla ravi-kumar-pilla added Enhancement Python Pull requests that update Python code labels Aug 14, 2023
@ravi-kumar-pilla ravi-kumar-pilla self-assigned this Aug 17, 2023
@ravi-kumar-pilla ravi-kumar-pilla moved this from Todo to In Progress in Kedro-Viz Aug 17, 2023
@ravi-kumar-pilla ravi-kumar-pilla moved this from In Progress to In Review in Kedro-Viz Aug 22, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Python Pull requests that update Python code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant