Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Migrate to Pydantic v2 #1719

Closed
1 task done
MarkusSagen opened this issue Jan 26, 2024 · 1 comment
Closed
1 task done

Proposal: Migrate to Pydantic v2 #1719

MarkusSagen opened this issue Jan 26, 2024 · 1 comment

Comments

@MarkusSagen
Copy link

Description

Proposal to migrate to Pydantic version 2 for kedro-viz

Context

For multiple project me and my team are using currently, we are using packages that already have dependency on Pydantic version 2. Since kedro-viz has a strict requirement on v1, we can't use it in our projects. As more projects are updating and require dependency resolution between dependencies, it will be harder to add kedro-viz to projects.

Possible Implementation

There are currently two relatively simple options to migrate from Pydantic v1 to v2:

  1. Change valildation decorators, methods, Types to conform to Pydantic v2. There is a script for this
  2. Still use v1 methods but call them from v2 from pydantic.v1 import BaseModel

https://docs.pydantic.dev/latest/migration/#continue-using-pydantic-v1-features

Out of the two options, I would think option 2. is the easier and would be easier to test

Would happily contribute to this and do the change if it is a good idea

Checklist

  • Include labels so that we can categorise your feature request
@astrojuanlu
Copy link
Member

Thanks @MarkusSagen for opening this issue! We are already tracking it in #1603. Please add your 👍🏽 emoji reaction there for visibility.

I'm closing this as a duplicate.

@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants