Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kedro viz build is not running hooks #1802

Closed
inigohidalgo opened this issue Mar 14, 2024 · 5 comments
Closed

kedro viz build is not running hooks #1802

inigohidalgo opened this issue Mar 14, 2024 · 5 comments

Comments

@inigohidalgo
Copy link

inigohidalgo commented Mar 14, 2024

Description

kedro viz build skips the hooks, whereas kedro viz run allows for choosing whether or not to run them. I would like to be able to do the same for kedro viz build.

https://linen-slack.kedro.org/t/16664076/in-kedro-viz-can-i-control-which-hooks-are-run-when-running-#0b14d294-110d-4755-91a9-ca80724414d1

@rashidakanchwala

@NeroOkwa
Copy link
Contributor

Backlog grooming note:

The action is to make kedro viz run and kedro viz build compatible e.g. adding/removing hooks.
Related (to be addressed first before this) - #1808

@NeroOkwa NeroOkwa moved this from Inbox to Backlog in Kedro-Viz Mar 25, 2024
@inigohidalgo
Copy link
Author

From that other thread

We want to enable this for all cli commands of kedro-viz including run , build and deploy

That would solve my need directly. If that issue is meant to track both build and run then my issue is redundant as that is exactly what I want, an include hooks parameter for Kedro viz build

@inigohidalgo
Copy link
Author

I don't have the availability to check this yet, but I assume that 9.0 closes this issue, right?

@rashidakanchwala
Copy link
Contributor

Yes, u should now be able to to do kedro viz build --include-hooks

@rashidakanchwala
Copy link
Contributor

I will close this issue as it's fixed :)

@github-project-automation github-project-automation bot moved this from Backlog to Done in Kedro-Viz Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants