Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed E2E test 'Export to png' #1855

Open
1 task
Huongg opened this issue Apr 11, 2024 · 0 comments
Open
1 task

Fix failed E2E test 'Export to png' #1855

Huongg opened this issue Apr 11, 2024 · 0 comments
Labels
Issue: Bug Report Javascript Pull requests that update Javascript code

Comments

@Huongg
Copy link
Contributor

Huongg commented Apr 11, 2024

Description

Related to #1848, in which upgraded to Node18 and React-script 5. This has caused the E2E test #TC-12 to fail only on CircleCI. However the test passed on local machine when run npm run cy:ci

Commit: 314fdb2

Context

This failed test needs to be fixed on CircleCI. I expect because there's some changes in the packages and perhaps it wasn't reflected the change on CircleCi, hence it leads to the test to fail

Steps to Reproduce

  1. Remove the commented out for the failed test #TC-12
  2. Make a PR and check if it will pass or fail on CircleCi
  3. The E2E test will fail

Expected Result

The E2E test should pass the check in CircleCI

Your Environment

Include as many relevant details as possible about the environment you experienced the bug in:

  • NodeJS version used (if relevant): 18
  • React-script: 5.0.1
  • Cypress: 13.3.0
  • Kedro version used (if relevant): 18
  • Python version used (if relevant): 3.9

Checklist

  • Include labels so that we can categorise your issue
@rashidakanchwala rashidakanchwala changed the title Fix failed E2E test #TC-12 Fix failed E2E test 'Export to png' Apr 11, 2024
@rashidakanchwala rashidakanchwala moved this to Inbox in Kedro-Viz Apr 22, 2024
@rashidakanchwala rashidakanchwala added the Javascript Pull requests that update Javascript code label Apr 22, 2024
@rashidakanchwala rashidakanchwala moved this from Inbox to Backlog in Kedro-Viz Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report Javascript Pull requests that update Javascript code
Projects
Status: Backlog
Development

No branches or pull requests

2 participants