Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor front-end component Command Copier #1994

Closed
1 task
rashidakanchwala opened this issue Jul 23, 2024 · 1 comment · Fixed by #1998
Closed
1 task

Refactor front-end component Command Copier #1994

rashidakanchwala opened this issue Jul 23, 2024 · 1 comment · Fixed by #1998

Comments

@rashidakanchwala
Copy link
Contributor

Description

The UI component Command Copier is currently using Metadata Value, which is specific to the Metadata component. Ideally, a UI component should be reusable across multiple higher-level components and should remain a pure component. However, in this case, it is using a component from a higher-level component, which is not clean.

This ticket is to refactor the Command Copier component to ensure it is a pure component and not dependent on higher-level components like Metadata Value.

Context

Why is this change important to you? How would you use it? How can it benefit other users?

Possible Implementation

(Optional) Suggest an idea for implementing the addition or change.

Possible Alternatives

(Optional) Describe any alternative solutions or features you've considered.

Checklist

  • Include labels so that we can categorise your feature request
@Huongg
Copy link
Contributor

Huongg commented Jul 24, 2024

hey I'll take this one as I've already done some of the refactor it in my slicing/run-command work

@Huongg Huongg self-assigned this Jul 24, 2024
@Huongg Huongg moved this from Inbox to In Progress in Kedro-Viz Jul 24, 2024
@Huongg Huongg mentioned this issue Jul 24, 2024
5 tasks
@Huongg Huongg moved this from In Progress to In Review in Kedro-Viz Jul 24, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants