-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spike: Try to reproduce non-deterministic rendering #2057
Comments
This will also enable having autoreload of Kedro-Viz in VSCode extension. |
A bit of history: as far as I understand, this is where the algorithm was introduced #185 |
And I don't see any references to randomness in the original paper that defines the Cassowary algorithm https://doi.org/10.1145/504704.504705 and no mention in the |
Thanks, @astrojuanlu, for your help with the above. This clarified that the issue was with Kedro-Viz. In the graph, we pass nodes, edges, and layers. I noticed that while the ordering of nodes and layers remained consistent, the edges’ order varied with each time the graph was calculated. I’ve added a sortEdges function to reduce randomness by ensuring we pass the same edges dictionary each time. It seems to be working now. I’ll open a PR so others can test it. |
Description
I'm always frustrated when I do
kedro viz run
twice and each time the rendered DAG is different.Context
I was reviewing #1966 and I wanted to see if the rendered pipeline is the same, but it's difficult because the sorting of the nodes can differ.
Checklist
The text was updated successfully, but these errors were encountered: